Pickers: Fix popover elevation and gap by danielchalmers · Pull Request #10270 · MudBlazor/MudBlazor

danielchalmers · 2024-11-18T17:14:47Z

Description

Regression by: #9993
Resolves #10235

Moves the drop shadow for inline pickers up to the popover itself and up to the picker element for others
Adds a mud-picker-popover class to the popover
MudPicker.Elevation is now nullable
- Defaults to MudGlobal.PopoverDefaults.Elevation for inline pickers
- Defaults to 0 for other variants
- This avoids the hardcoded logic around the default of 8; you couldn't use that number to add an elevation for other variants

Additionally resolves issue caused by #10071 where there was a (now no longer needed) margin between the picker input and the picker itself:

This PR may or may not be considered a breaking change.

How Has This Been Tested?

visually

Type of Changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
Documentation (fix or improvement to the website or code docs)

Checklist

The PR is submitted to the correct branch (dev).
My code follows the code style of this project.
I've added relevant tests.

danielchalmers · 2024-11-18T17:20:21Z

Tested visually briefly, needs confirmation that it fixes the issues mentioned. If any further refactoring or unit tests is wanted, kindly edit the branch.

sonarqubecloud · 2024-11-18T17:26:14Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

codecov · 2024-11-18T17:27:22Z

Codecov Report

Attention: Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 91.51%. Comparing base (a68891e) to head (f3f5866).
Report is 4 commits behind head on dev.

Files with missing lines	Patch %	Lines
src/MudBlazor/Components/Picker/MudPicker.razor.cs	80.00%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##              dev   #10270      +/-   ##
==========================================
- Coverage   91.53%   91.51%   -0.02%     
==========================================
  Files         414      414              
  Lines       12989    12988       -1     
  Branches     2452     2452              
==========================================
- Hits        11889    11886       -3     
  Misses        555      555              
- Partials      545      547       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚨 Try these New Features:

Flaky Tests Detection - Detect and resolve failed and flaky tests
JS Bundle Analysis - Avoid shipping oversized bundles

ScarletKuro · 2024-11-19T19:11:59Z

Did not check the PR yet, but found another regression by this PR;#9993 (comment)

Found another regression by this PR.
Arrow tooltips do not show the arrow:
https://dev.mudblazor.com/components/tooltip#arrow-tooltips

ScarletKuro · 2024-11-19T19:12:54Z

Tested visually briefly, needs confirmation that it fixes the issues mentioned. If any further refactoring or unit tests is wanted, kindly edit the branch.

Want to help to test it visually @jperson2000?

jperson2000 · 2024-11-20T06:52:40Z

Want to help to test it visually @jperson2000?

You bet. It looks like we're testing all popovers after this change. Here's what I see for components when I test this branch: