Skip to content

MudInput: Remove @onmousewheel#10221

Merged
ScarletKuro merged 2 commits intoMudBlazor:devfrom
ScarletKuro:onmousewheel
Nov 10, 2024
Merged

MudInput: Remove @onmousewheel#10221
ScarletKuro merged 2 commits intoMudBlazor:devfrom
ScarletKuro:onmousewheel

Conversation

@ScarletKuro
Copy link
Member

Description

As discussed in discord and in discussion #9946 (reply in thread)

The onmousewheel should be removed as it's deprecated API and onwheel should be used instead.
See:
https://developer.mozilla.org/en-US/docs/Web/API/Element/mousewheel_event
https://www.w3schools.com/tags/att_onmousewheel.asp

Checklist

  • The PR is submitted to the correct branch (dev).
  • My code follows the code style of this project.
  • I've added relevant tests.

@ScarletKuro ScarletKuro added the refactor Reorganizes code and has no changes to the API or functionality in the main library label Nov 9, 2024
@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 9, 2024

Copy link
Member

@danielchalmers danielchalmers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could add a comment clarifying the difference between the two events on OnMouseWheel, or even rename it, but LGTM as is

@ScarletKuro ScarletKuro merged commit 4262a56 into MudBlazor:dev Nov 10, 2024
@ScarletKuro ScarletKuro deleted the onmousewheel branch November 10, 2024 11:43
LLauter pushed a commit to cannellamedia/MudBlazor that referenced this pull request Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

refactor Reorganizes code and has no changes to the API or functionality in the main library

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants