DataGridTests: Fix test failure by using Invariant Culture#10220
DataGridTests: Fix test failure by using Invariant Culture#10220ScarletKuro merged 3 commits intoMudBlazor:devfrom
Conversation
I think we should find the reason instead of this workaround. |
|
Yeah, it would be nice to find the root cause of this problem.
It seems like there’s none between the date and the time, and the What happens if you remove or replace |
|
I had a hunch this might be related to ICU... A quick google search confirmed it: |
|
Just to say I am on mac and get the same error |
|
@ScarletKuro I tried your suggestion of setting culture to Invariant and it gives |
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #10220 +/- ##
==========================================
+ Coverage 91.22% 91.52% +0.30%
==========================================
Files 412 414 +2
Lines 12541 12989 +448
Branches 2448 2452 +4
==========================================
+ Hits 11440 11888 +448
+ Misses 557 555 -2
- Partials 544 546 +2 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
|
@ScarletKuro works locally for me now, Ready to merge. |
|
ty |
…#10220) Co-authored-by: Mike Surcouf <[email protected]>
…#10220) Co-authored-by: Mike Surcouf <[email protected]>
…#10220) Co-authored-by: Mike Surcouf <[email protected]>
Co-authored-by: Anu6is <[email protected]> Co-authored-by: Samuel Meenzen <[email protected]> Co-authored-by: Mike Surcouf <[email protected]>



Description
On my machine this test was always failing because for some reason a
NNBSPchar instead of a whitespace is added:Because the type of whitespace does not actually matter I've just replaced it with a normal whitespace to make the assertion happy.
How Has This Been Tested?
n/a
Type of Changes
Checklist
dev).