MudSelect, MudMenu: Fix max height exceeds window#10216
Conversation
…en height and is a mud-list. (mud-select or mud-menu). This enables overflow to work as intended.
github-actions
bot
added
bug
|
|
danielchalmers
left a comment
danielchalmers
left a comment
There was a problem hiding this comment.
Nice! Could you add a bit of a gap at the end so it doesn't look like it's being clipped?
src/MudBlazor.UnitTests.Viewer/TestComponents/Menu/MenuNoFlipScrollBarTest.razor
Outdated
Show resolved
Hide resolved
Went with 8px, I think it looks good. let me know or is there a standard amount I should use?
|
|
Great! Maybe a little extra padding, 24px - Here's what google docs looks like:
Is it intended that the submenu doesn't grow upwards? All the items could fit on the page if it expanded
|
|
|
so the menu won't fit if it goes down from opening position. Moving the sub-menu "up" seemed odd to me so I was happy when you posted the spec showing a scrollbar. Here's 24px
|
henon
changed the title
|
Thanks Versile Johnson II |
4 participants
Description
Popover mud-list items create scrollbars in the main window when they exceed screen height. This can only happen if the flip function can't flip them without exceeding the top or left. (right in RTL) These changes add a max-height property if and ONLY if a mud-list in a popover would create a scrollbar outside of itself.
Resolves #10204
How Has This Been Tested?
Visual Tests Below
Type of Changes
Checklist
dev).