Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.23%. Comparing base (12c5dec) to head (8ff3433).
Report is 3 commits behind head on dev.

@@            Coverage Diff             @@
##              dev   #10213      +/-   ##
==========================================
+ Coverage   91.21%   91.23%   +0.02%     
==========================================
  Files         411      412       +1     
  Lines       12506    12536      +30     
  Branches     2439     2446       +7     
==========================================
+ Hits        11407    11437      +30     
  Misses        555      555              
  Partials      544      544              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@henon, if you approve the NullObject, I will write tests for both the NullObject and the DataGrid grouping. Otherwise, I don’t want to waste my energy.

There is no easier way, as dictionaries don’t support null keys. I do think the way the dictionary are used in these two cases is a code smell, but having this wrapper is the easiest solution compared to introducing our own nullable dictionary or using something other than a dictionary and ending up having to rewrite everything. This NullObject is very lightweight and shouldn’t impact performance or memory—there’s no boxing/unboxing in the equality comparison link.

Ok, this is a good solution. Just the name is not good. Currently it suggests a Null Object which is a design pattern. Class doesn't represent a classical null object because it does not represent just a null value, it represents a value/object that might also be null. So it is a nullable wrapper. Maybe we should call it that (NullableWrapper or NullableObject)?

This feature (bug fix) is ready. I think it turned out to be a very decent change.

upd: Actually tmr I want to do few adjustments and test with structs generics just in case done

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud