IJSRuntimeExtensions: Fix when pre-rendering#10142
Merged
ScarletKuro merged 2 commits intoMudBlazor:devfrom Oct 30, 2024
Merged
IJSRuntimeExtensions: Fix when pre-rendering#10142ScarletKuro merged 2 commits intoMudBlazor:devfrom
ScarletKuro merged 2 commits intoMudBlazor:devfrom
Conversation
github-actions
bot
added
bug
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #10142 +/- ##
=======================================
Coverage 91.18% 91.18%
=======================================
Files 411 411
Lines 12480 12481 +1
Branches 2431 2432 +1
=======================================
+ Hits 11380 11381 +1
Misses 556 556
Partials 544 544 ☔ View full report in Codecov by Sentry. |
versile2
pushed a commit
to versile2/MudBlazor
that referenced
this pull request
Oct 31, 2024
LLauter
pushed a commit
to cannellamedia/MudBlazor
that referenced
this pull request
Dec 16, 2024
This was referenced Aug 18, 2025
This was referenced Oct 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes: #10141
Regression from: #9997
Apparently, there are are two
JSRuntimetypes that throw similar error:UnsupportedJavaScriptRuntimeduring static SSR.RemoteJSRuntime- during SSR pre-render.In the #9997 I removed when it was just checking for word "prerending" in the exception message and went for checking the JS runtime type instead.
The
IsJsInteropAvailabledoesn't help here, as it happening not on a component level, but during pre-render the DI is disposing the whole container, theBrowserViewportServiceis part of it, and it invokesDisposeAsyncthat has a JS call, so there is nothing better than just ignore this errors.How Has This Been Tested?
Manually + bUnit test
Type of Changes
Checklist
dev).