Skip to content

NumericField: Add nullable annotation#10123

Merged
ScarletKuro merged 5 commits intoMudBlazor:devfrom
meenzen:feat/numeric-field-nullable
Nov 9, 2024
Merged

NumericField: Add nullable annotation#10123
ScarletKuro merged 5 commits intoMudBlazor:devfrom
meenzen:feat/numeric-field-nullable

Conversation

@meenzen
Copy link
Contributor

@meenzen meenzen commented Oct 28, 2024

Description

Part of #6535

How Has This Been Tested?

none

Type of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (fix or improvement to the website or code docs)

Checklist

  • The PR is submitted to the correct branch (dev).
  • My code follows the code style of this project.
  • I've added relevant tests.

@github-actions github-actions bot added enhancement Adds a new feature or enhances existing functionality (not fixing a defect) in the main library PR: needs review labels Oct 28, 2024
@meenzen meenzen requested a review from ScarletKuro October 28, 2024 22:09
@codecov
Copy link

codecov bot commented Oct 29, 2024

Codecov Report

Attention: Patch coverage is 71.42857% with 4 lines in your changes missing coverage. Please review.

Project coverage is 91.22%. Comparing base (9a9c40c) to head (6b69db4).
Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
...r/Components/NumericField/MudNumericField.razor.cs 71.42% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #10123      +/-   ##
==========================================
- Coverage   91.23%   91.22%   -0.02%     
==========================================
  Files         412      412              
  Lines       12536    12541       +5     
  Branches     2446     2448       +2     
==========================================
+ Hits        11437    11440       +3     
- Misses        555      557       +2     
  Partials      544      544              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ScarletKuro ScarletKuro added hacktoberfest Hacktoberfest 2021 hacktoberfest-accepted Issues and PRs which were accepted as Hacktoberfest submissions hacktoberfest2024 and removed PR: needs review labels Nov 9, 2024
@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 9, 2024

@ScarletKuro ScarletKuro merged commit f028a0f into MudBlazor:dev Nov 9, 2024
@meenzen meenzen deleted the feat/numeric-field-nullable branch November 9, 2024 20:58
LLauter pushed a commit to cannellamedia/MudBlazor that referenced this pull request Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Adds a new feature or enhances existing functionality (not fixing a defect) in the main library hacktoberfest Hacktoberfest 2021 hacktoberfest2024 hacktoberfest-accepted Issues and PRs which were accepted as Hacktoberfest submissions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants