Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.18%. Comparing base (bacf629) to head (7489ce3).
Report is 48 commits behind head on dev.

@@           Coverage Diff           @@
##              dev   #10116   +/-   ##
=======================================
  Coverage   91.17%   91.18%           
=======================================
  Files         411      411           
  Lines       12481    12483    +2     
  Branches     2429     2432    +3     
=======================================
+ Hits        11380    11382    +2     
  Misses        557      557           
  Partials      544      544           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Wouldn't it better to make just

public record BreadcrumbItem(string Text, string? Href, bool Disabled = false, string? Icon = null);

?

Wouldn't it better to make just

public record BreadcrumbItem(string Text, string? Href, bool Disabled = false, string? Icon = null);

?

That's a breaking change if you reference the variable name in the constructor: new BreadcrumbItem(href: "..."). There's no href anymore.

That's a breaking change if you reference the variable name in the constructor: new BreadcrumbItem(href: "..."). There's no href anymore.

That's very interesting, I thought the generated code would lowercase it? But seems like I'm wrong

public BreadcrumbItem([Nullable(1)] string Text, string Href, bool Disabled = false, string Icon = null)
{
            <Text>k__BackingField = Text;
            <Href>k__BackingField = Href;
            <Disabled>k__BackingField = Disabled;
            <Icon>k__BackingField = Icon;
            base..ctor();
}

No idea why would they do that, considering that record is just a "superstructure" over class.
Ty, learned something new today.

I don't think it's a breaking change either? The properties were readonly already, all you added is that with record it implements ToString and Equality etc which is a good thing.

@ScarletKuro @henon Breaks inheritance because it's no longer a class.

CS8865: Only records may inherit from records.

Migration guide could say

BreadcrumbItem is now a record and any class that inherits from it must be updated to a record as well

Added to v8.0.0 Migration Guide
#9953