Skip to content

MudStepper: Fix CompletedContent not shown in Vertical variant#10075

Merged
ScarletKuro merged 1 commit intoMudBlazor:devfrom
henon:stepper-vertical-completed-content
Oct 22, 2024
Merged

MudStepper: Fix CompletedContent not shown in Vertical variant#10075
ScarletKuro merged 1 commit intoMudBlazor:devfrom
henon:stepper-vertical-completed-content

Conversation

@henon
Copy link
Contributor

@henon henon commented Oct 22, 2024

Description

CompletedContent isn't shown for stepper in Vertical mode
Resolves #10047

How Has This Been Tested?

unit | visually

Type of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (fix or improvement to the website or code docs)

Checklist

  • The PR is submitted to the correct branch (dev).
  • My code follows the code style of this project.
  • I've added relevant tests.

@henon henon added bug Unexpected behavior or functionality not working as intended hacktoberfest Hacktoberfest 2021 hacktoberfest-accepted Issues and PRs which were accepted as Hacktoberfest submissions hacktoberfest2024 labels Oct 22, 2024
@codecov
Copy link

codecov bot commented Oct 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.13%. Comparing base (3a8849c) to head (0a9a312).
Report is 2 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev   #10075   +/-   ##
=======================================
  Coverage   91.13%   91.13%           
=======================================
  Files         411      411           
  Lines       12482    12482           
  Branches     2422     2422           
=======================================
  Hits        11376    11376           
  Misses        560      560           
  Partials      546      546           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ScarletKuro ScarletKuro merged commit dc3d538 into MudBlazor:dev Oct 22, 2024
@ScarletKuro
Copy link
Member

Do want this in v7?

@henon
Copy link
Contributor Author

henon commented Oct 22, 2024

#10047

Yes, it is a blatant oversight

ScarletKuro pushed a commit that referenced this pull request Oct 22, 2024
@henon henon deleted the stepper-vertical-completed-content branch November 12, 2024 09:25
LLauter pushed a commit to cannellamedia/MudBlazor that referenced this pull request Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Unexpected behavior or functionality not working as intended hacktoberfest Hacktoberfest 2021 hacktoberfest2024 hacktoberfest-accepted Issues and PRs which were accepted as Hacktoberfest submissions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MudStepper: CompletedContent not shown when stepper is Vertical

3 participants