Skip to content

EventListener: Clean up, make implementations internal, add xmodoc#10051

Merged
ScarletKuro merged 5 commits intoMudBlazor:devfrom
ScarletKuro:eventlistenerimprove
Oct 19, 2024
Merged

EventListener: Clean up, make implementations internal, add xmodoc#10051
ScarletKuro merged 5 commits intoMudBlazor:devfrom
ScarletKuro:eventlistenerimprove

Conversation

@ScarletKuro
Copy link
Member

@ScarletKuro ScarletKuro commented Oct 19, 2024 •
edited
Loading

Description

Improves overall code quality
The implementation should always be internal.
Removed IDiposable.

Type of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (fix or improvement to the website or code docs)

Checklist

  • The PR is submitted to the correct branch (dev).
  • My code follows the code style of this project.
  • I've added relevant tests.

@github-actions github-actions bot added breaking change This change will require consumer code updates PR: needs review labels Oct 19, 2024
@codecov
Copy link

codecov bot commented Oct 19, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 77.77778% with 2 lines in your changes missing coverage. Please review.

Project coverage is 91.10%. Comparing base (1f8e8a9) to head (8c34015).
Report is 2 commits behind head on dev.

Files with missing lines Patch % Lines
...azor/Services/EventManager/EventListenerFactory.cs 0.00% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##              dev   #10051      +/-   ##
==========================================
- Coverage   91.10%   91.10%   -0.01%     
==========================================
  Files         410      410              
  Lines       12488    12476      -12     
  Branches     2424     2421       -3     
==========================================
- Hits        11377    11366      -11     
+ Misses        566      565       -1     
  Partials      545      545

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ScarletKuro ScarletKuro mentioned this pull request Oct 19, 2024
Closed
@ScarletKuro
Copy link
Member Author

ScarletKuro commented Oct 19, 2024

Added to the v8 migration guide at #9953

@ScarletKuro ScarletKuro merged commit 6ac51c8 into MudBlazor:dev Oct 19, 2024
@ScarletKuro ScarletKuro deleted the eventlistenerimprove branch October 19, 2024 15:05
LLauter pushed a commit to cannellamedia/MudBlazor that referenced this pull request Dec 16, 2024
@ScarletKuro @LLauter
EventListener: Clean up, make implementations internal, add xmodoc (M…
7cee09d 
…udBlazor#10051)
@dependabot dependabot bot mentioned this pull request Aug 1, 2025
Closed
This was referenced Aug 18, 2025
Closed
Merged
@dependabot dependabot bot mentioned this pull request Aug 27, 2025
Merged
@dependabot dependabot bot mentioned this pull request Sep 8, 2025
Closed
@dependabot dependabot bot mentioned this pull request Sep 22, 2025
Closed
This was referenced Oct 5, 2025
Merged
Open
Open
@dependabot dependabot bot mentioned this pull request Nov 3, 2025
Merged
@dependabot dependabot bot mentioned this pull request Nov 12, 2025
Closed
@dependabot dependabot bot mentioned this pull request Jan 3, 2026
Closed
@dependabot dependabot bot mentioned this pull request Jan 11, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

breaking change This change will require consumer code updates

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@ScarletKuro