BrowserViewportService: Remove semaphore, Drawer: Use IAsyncDisposable#10020
Merged
ScarletKuro merged 1 commit intoMudBlazor:devfrom Oct 14, 2024
Merged
BrowserViewportService: Remove semaphore, Drawer: Use IAsyncDisposable#10020ScarletKuro merged 1 commit intoMudBlazor:devfrom
ScarletKuro merged 1 commit intoMudBlazor:devfrom
Conversation
github-actions
bot
added
bug
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #10020 +/- ##
==========================================
- Coverage 91.00% 90.99% -0.01%
==========================================
Files 409 409
Lines 12518 12508 -10
Branches 2446 2442 -4
==========================================
- Hits 11392 11382 -10
Misses 573 573
Partials 553 553 ☔ View full report in Codecov by Sentry. |
LLauter
pushed a commit
to cannellamedia/MudBlazor
that referenced
this pull request
Dec 16, 2024
This was referenced Aug 1, 2025
This was referenced Aug 18, 2025
This was referenced Oct 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes: #10017
Remove semaphore.
Also Drawer was not using
IAsyncDisposablefor some reason (artifacts from the past?), which also contributed to race conditions as Dispose wasn't awaited, because theoretically the same should have happened to popover when it used locks in past.How Has This Been Tested?
Type of Changes
Checklist
dev).