DialogService: Mark sync API as obsolete#10000
Merged
ScarletKuro merged 3 commits intoMudBlazor:devfrom Oct 13, 2024
Merged
Conversation
github-actions
bot
added
enhancement
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #10000 +/- ##
==========================================
+ Coverage 89.82% 90.95% +1.12%
==========================================
Files 412 408 -4
Lines 11878 12534 +656
Branches 2364 2446 +82
==========================================
+ Hits 10670 11400 +730
+ Misses 681 579 -102
- Partials 527 555 +28 ☔ View full report in Codecov by Sentry. |
henon
approved these changes
Oct 13, 2024
Contributor
henon
left a comment
henon
left a comment
There was a problem hiding this comment.
All looking good. Is the sync api still in use in our docs or was it already replaced earlier?
Member
Author
Everything was replaced long time ago. |
LLauter
pushed a commit
to cannellamedia/MudBlazor
that referenced
this pull request
Dec 16, 2024
This was referenced Aug 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We should have done this a long time ago in v7, but it is what it is. It wasn't marked obsolete, so people had no idea that it would be beneficial to switch to the async versions. I'm against removing them in v8 as for now, as it would result in too many breaking changes. Many of the breaking changes in the current v8 are very minor and rare to encounter.
NB!: I also moved
DialogOptions,DialogParameters,DialogParametersGeneric,DialogReference,IDialogReferencetoServices/Dialogbecause this is their logical place, They are essential for the service, and they shouldn't be placed near the components. The namespaces weren't touched.Type of Changes
Checklist
dev).