Repository navigation
Commit 24f9ad1
authored
fix: make consolidated metadata nesting independent of persisted key order (zarr-developers#4227)
* fix: make consolidated metadata nesting independent of persisted key order
`ConsolidatedMetadata._flat_to_nested` grouped the flat keys with
`itertools.groupby` over keys sorted by depth alone. `groupby` only groups
*consecutive* runs, so when a parent's children were not adjacent it emitted
several runs for the same parent and the surrounding dict comprehension kept
only the last one. Every child in the earlier runs was silently never
re-parented, and lingered as a bogus slash-containing key at the top level,
making it unreachable through the consolidated metadata.
The persisted key order is arbitrary, so nesting must not depend on it. Group
by parent with an accumulating mapping instead.
This is reachable from zarr-python itself: `to_dict` sorts keys by
`(depth, NFKC-casefold(key))`, so sibling subtrees whose names differ only by
case interleave and trigger exactly this pattern.
Fixes zarr-developers#4226
Assisted-by: ClaudeCode:claude-opus-5
* docs: add changelog entry for 273
Assisted-by: ClaudeCode:claude-opus-5
* docs: renumber changelog fragment to the upstream PR number
Assisted-by: ClaudeCode:claude-opus-51 parent a994a4f commit 24f9ad1
3 files changed
Lines changed: 69 additions & 5 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | 3 | | |
4 | | - | |
5 | 4 | | |
6 | 5 | | |
7 | 6 | | |
| |||
237 | 236 | | |
238 | 237 | | |
239 | 238 | | |
240 | | - | |
241 | | - | |
242 | | - | |
243 | | - | |
| 239 | + | |
| 240 | + | |
| 241 | + | |
| 242 | + | |
| 243 | + | |
| 244 | + | |
244 | 245 | | |
245 | 246 | | |
246 | 247 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
839 | 839 | | |
840 | 840 | | |
841 | 841 | | |
| 842 | + | |
| 843 | + | |
| 844 | + | |
| 845 | + | |
| 846 | + | |
| 847 | + | |
| 848 | + | |
| 849 | + | |
| 850 | + | |
| 851 | + | |
| 852 | + | |
| 853 | + | |
| 854 | + | |
| 855 | + | |
| 856 | + | |
| 857 | + | |
| 858 | + | |
| 859 | + | |
| 860 | + | |
| 861 | + | |
| 862 | + | |
| 863 | + | |
| 864 | + | |
| 865 | + | |
| 866 | + | |
| 867 | + | |
| 868 | + | |
| 869 | + | |
| 870 | + | |
| 871 | + | |
| 872 | + | |
| 873 | + | |
| 874 | + | |
| 875 | + | |
| 876 | + | |
| 877 | + | |
| 878 | + | |
| 879 | + | |
| 880 | + | |
| 881 | + | |
| 882 | + | |
| 883 | + | |
| 884 | + | |
| 885 | + | |
| 886 | + | |
| 887 | + | |
| 888 | + | |
| 889 | + | |
| 890 | + | |
| 891 | + | |
| 892 | + | |
| 893 | + | |
| 894 | + | |
| 895 | + | |
| 896 | + | |
| 897 | + | |
| 898 | + | |
| 899 | + | |
| 900 | + | |
| 901 | + | |
| 902 | + | |
| 903 | + | |
0 commit comments