Skip to content

Commit f72f5f4

Browse files
authored
Adds new gallery benchmarks to windows (skia and impeller) (flutter#191454)
fixes flutter#191430 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [AI contribution guidelines] and understand my responsibilities, or I am not using AI tools. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. If this change needs to override an active code freeze, provide a comment explaining why. The code freeze workflow can be overridden by code reviewers. See pinned issues for any active code freezes with guidance. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [AI contribution guidelines]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#ai-contribution-guidelines [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
1 parent 394eedf commit f72f5f4

5 files changed

Lines changed: 56 additions & 1 deletion

File tree

‎.ci.yaml‎

Lines changed: 27 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7310,6 +7310,33 @@ targets:
73107310
]
73117311
task_name: windows_home_scroll_perf__timeline_summary
73127312

7313+
- name: Windows new_gallery_windows_impeller__transition_perf
7314+
recipe: devicelab/devicelab_drone
7315+
presubmit: false
7316+
bringup: true
7317+
timeout: 60
7318+
properties:
7319+
tags: >
7320+
["devicelab", "hostonly", "windows"]
7321+
dependencies: >-
7322+
[
7323+
{"dependency": "vs_build", "version": "version:vs2019"}
7324+
]
7325+
task_name: new_gallery_windows_impeller__transition_perf
7326+
7327+
- name: Windows new_gallery_windows_skia__transition_perf
7328+
recipe: devicelab/devicelab_drone
7329+
presubmit: false
7330+
bringup: true
7331+
timeout: 60
7332+
properties:
7333+
tags: >
7334+
["devicelab", "hostonly", "windows"]
7335+
dependencies: >-
7336+
[
7337+
{"dependency": "vs_build", "version": "version:vs2019"}
7338+
]
7339+
task_name: new_gallery_windows_skia__transition_perf
73137340

73147341
- name: Windows hello_world_win_desktop__compile
73157342
recipe: devicelab/devicelab_drone

‎TESTOWNERS‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -255,6 +255,8 @@
255255
/dev/devicelab/bin/tasks/complex_layout_scroll_perf_macos_impeller__timeline_summary.dart @gaaclarke @flutter/desktop
256256
/dev/devicelab/bin/tasks/complex_layout_scroll_perf_macos__timeline_summary.dart @cbracken @flutter/desktop
257257
/dev/devicelab/bin/tasks/new_gallery_macos_impeller__transition_perf.dart @b-luk @flutter/engine
258+
/dev/devicelab/bin/tasks/new_gallery_windows_impeller__transition_perf.dart @gaaclarke @flutter/engine
259+
/dev/devicelab/bin/tasks/new_gallery_windows_skia__transition_perf.dart @gaaclarke @flutter/engine
258260
/dev/devicelab/bin/tasks/complex_layout_win_desktop__compile.dart @yaakovschectman @flutter/desktop
259261
/dev/devicelab/bin/tasks/complex_layout_win_desktop__start_up.dart @yaakovschectman @flutter/desktop
260262
/dev/devicelab/bin/tasks/dart_plugin_registry_test.dart @stuartmorgan-g @flutter/plugin
Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,13 @@
1+
// Copyright 2014 The Flutter Authors. All rights reserved.
2+
// Use of this source code is governed by a BSD-style license that can be
3+
// found in the LICENSE file.
4+
5+
import 'package:flutter_devicelab/framework/devices.dart';
6+
import 'package:flutter_devicelab/framework/framework.dart';
7+
import 'package:flutter_devicelab/tasks/new_gallery.dart';
8+
9+
Future<void> main() async {
10+
deviceOperatingSystem = DeviceOperatingSystem.windows;
11+
12+
await task(NewGalleryPerfTest(enableImpeller: true).run);
13+
}
Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,13 @@
1+
// Copyright 2014 The Flutter Authors. All rights reserved.
2+
// Use of this source code is governed by a BSD-style license that can be
3+
// found in the LICENSE file.
4+
5+
import 'package:flutter_devicelab/framework/devices.dart';
6+
import 'package:flutter_devicelab/framework/framework.dart';
7+
import 'package:flutter_devicelab/tasks/new_gallery.dart';
8+
9+
Future<void> main() async {
10+
deviceOperatingSystem = DeviceOperatingSystem.windows;
11+
12+
await task(NewGalleryPerfTest(enableImpeller: false).run);
13+
}

‎dev/devicelab/lib/tasks/new_gallery.dart‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ class NewGalleryPerfTest extends PerfTest {
1616
'${flutterDirectory.path}/dev/integration_tests/new_gallery',
1717
'test_driver/transitions_perf.dart',
1818
timelineFileName,
19-
createPlatforms: <String>['android', 'ios', 'web', 'macos'],
19+
createPlatforms: <String>['android', 'ios', 'web', 'macos', 'windows'],
2020
enableMergedPlatformThread: true,
2121
);
2222
}

0 commit comments

Comments
 (0)