Repository navigation
Commit 29367a5
authored
Give the Vulkan test context the extensions Impeller requires (flutter#193002)
Impeller's capability check reads the extension lists the embedder
declares rather than querying the driver. It wants `VK_KHR_surface` plus
one WSI extension on the instance, and `VK_KHR_swapchain` on the device.
`TestVulkanContext` enables none of them and reports none, so Impeller
refuses the context:
```
[ERROR:impeller/renderer/backend/vulkan/capabilities_vk.cc(105)] Could not find the surface extension.
[ERROR:impeller/renderer/backend/vulkan/context_vk.cc(187)] Device has insufficient capabilities.
[ERROR:shell/platform/embedder/embedder_surface_vulkan_impeller.cc(78)] Failed to initialize Vulkan Context.
```
So no Impeller Vulkan embedder test can run at all today.
Request the surface extensions the ICD offers, create the logical device
with `VK_KHR_swapchain`, and report both lists through
`FlutterVulkanRendererConfig`. SwiftShader offers all of them. Falls
back to a device without the extension if the ICD refuses it, and
reports nothing when the surface extensions are absent, so a context
that cannot serve Impeller still serves the Skia tests exactly as
before.
None of this is used to present — the tests render into images — but
Impeller will not build a context without it.
Also sets `FlutterVulkanImage.struct_size` in the backing store
producer. The API says it must be `sizeof(FlutterVulkanImage)`; the Skia
path never checks, so leaving it zero went unnoticed.
## Tests
No new ones. This is fixture plumbing whose effect is that the Impeller
tests in the fifth and sixth of the series can run; the existing Skia
Vulkan tests must keep passing, and do.
Fourth of six, from flutter#187525. The fifth and sixth need it.1 parent b63b216 commit 29367a5
4 files changed
Lines changed: 183 additions & 2 deletions
File tree
- engine/src/flutter
- shell/platform/embedder/tests
- testing
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
84 | 84 | | |
85 | 85 | | |
86 | 86 | | |
| 87 | + | |
87 | 88 | | |
88 | 89 | | |
89 | 90 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
29 | 29 | | |
30 | 30 | | |
31 | 31 | | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
32 | 40 | | |
33 | 41 | | |
34 | 42 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2 | 2 | | |
3 | 3 | | |
4 | 4 | | |
| 5 | + | |
5 | 6 | | |
6 | 7 | | |
7 | 8 | | |
| 9 | + | |
8 | 10 | | |
9 | 11 | | |
10 | 12 | | |
| |||
23 | 25 | | |
24 | 26 | | |
25 | 27 | | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
26 | 72 | | |
27 | 73 | | |
28 | 74 | | |
| |||
46 | 92 | | |
47 | 93 | | |
48 | 94 | | |
| 95 | + | |
49 | 96 | | |
50 | | - | |
| 97 | + | |
51 | 98 | | |
52 | 99 | | |
53 | 100 | | |
| |||
58 | 105 | | |
59 | 106 | | |
60 | 107 | | |
61 | | - | |
| 108 | + | |
62 | 109 | | |
63 | 110 | | |
64 | 111 | | |
65 | 112 | | |
66 | 113 | | |
| 114 | + | |
| 115 | + | |
| 116 | + | |
| 117 | + | |
| 118 | + | |
| 119 | + | |
| 120 | + | |
67 | 121 | | |
68 | 122 | | |
69 | 123 | | |
| |||
107 | 161 | | |
108 | 162 | | |
109 | 163 | | |
| 164 | + | |
| 165 | + | |
| 166 | + | |
| 167 | + | |
| 168 | + | |
| 169 | + | |
| 170 | + | |
| 171 | + | |
| 172 | + | |
| 173 | + | |
| 174 | + | |
| 175 | + | |
| 176 | + | |
| 177 | + | |
| 178 | + | |
| 179 | + | |
| 180 | + | |
| 181 | + | |
| 182 | + | |
| 183 | + | |
| 184 | + | |
| 185 | + | |
| 186 | + | |
| 187 | + | |
| 188 | + | |
| 189 | + | |
| 190 | + | |
| 191 | + | |
| 192 | + | |
| 193 | + | |
| 194 | + | |
| 195 | + | |
| 196 | + | |
| 197 | + | |
| 198 | + | |
| 199 | + | |
| 200 | + | |
| 201 | + | |
| 202 | + | |
| 203 | + | |
| 204 | + | |
| 205 | + | |
| 206 | + | |
| 207 | + | |
| 208 | + | |
| 209 | + | |
| 210 | + | |
| 211 | + | |
| 212 | + | |
| 213 | + | |
| 214 | + | |
| 215 | + | |
| 216 | + | |
| 217 | + | |
| 218 | + | |
| 219 | + | |
| 220 | + | |
| 221 | + | |
| 222 | + | |
| 223 | + | |
| 224 | + | |
| 225 | + | |
| 226 | + | |
| 227 | + | |
| 228 | + | |
| 229 | + | |
| 230 | + | |
| 231 | + | |
| 232 | + | |
| 233 | + | |
| 234 | + | |
| 235 | + | |
| 236 | + | |
| 237 | + | |
| 238 | + | |
| 239 | + | |
| 240 | + | |
| 241 | + | |
| 242 | + | |
| 243 | + | |
| 244 | + | |
| 245 | + | |
| 246 | + | |
| 247 | + | |
| 248 | + | |
| 249 | + | |
| 250 | + | |
| 251 | + | |
| 252 | + | |
| 253 | + | |
| 254 | + | |
| 255 | + | |
| 256 | + | |
| 257 | + | |
| 258 | + | |
| 259 | + | |
| 260 | + | |
| 261 | + | |
110 | 262 | | |
111 | 263 | | |
112 | 264 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
5 | 5 | | |
6 | 6 | | |
7 | 7 | | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
8 | 11 | | |
9 | 12 | | |
10 | 13 | | |
| |||
26 | 29 | | |
27 | 30 | | |
28 | 31 | | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
29 | 42 | | |
30 | 43 | | |
31 | 44 | | |
32 | 45 | | |
33 | 46 | | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
34 | 54 | | |
35 | 55 | | |
36 | 56 | | |
| |||
0 commit comments