You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit d0536c0
Browse filesBrowse the repository at this point in the historyBrowse files
[refine](column) use strong-typed ColumnUInt8 for null_map in ColumnNullable (apache#63491)
### What problem does this PR solve?
The null_map column in `ColumnNullable` was stored as a generic
`IColumn::WrappedPtr`, requiring `assert_cast<ColumnUInt8>` at every
call site that accessed it. This had two problems:
1. **Redundant runtime casts**: Every access to `get_null_map_column()`
or `get_null_map_column_ptr()` performed an `assert_cast`, adding
unnecessary overhead on hot paths (filter evaluation, null propagation,
etc.).
2. **Type safety**: The generic `WrappedPtr` type provided no
compile-time guarantee that the null map is always a `ColumnUInt8`,
making it possible to accidentally store a wrong column type.
Root cause: The `_null_map` member was typed as a generic
`IColumn::WrappedPtr` instead of the concrete `ColumnUInt8::WrappedPtr`.
Fix: Change `_null_map` to `ColumnUInt8::WrappedPtr` so the type is
fixed at the member level. The constructor now validates and converts to
`ColumnUInt8::MutablePtr` on entry via a helper
`assert_mutable_null_map()`. All call sites that previously did
`assert_cast<ColumnUInt8>` now get the correct type directly.
### Release note
None
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [ ] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg:
apache/doris-website#1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR
should merge into -->
0 commit comments