File size checking & log-file reopening by shikharvashistha · Pull Request #18 · MrAnno/syslog-ng

shikharvashistha · 2022-08-28T06:30:12Z

This pull implements the functionality to check file size for rotation & reopening if required.

github-actions · 2022-08-28T06:30:24Z

No news file has been detected. Please write one, if applicable.

This commit introduces functionality for setting up date format based of last_rotation_time Signed-off-by: Shikhar Vashistha <[email protected]>

This commit includes the file size checking and renaming if it exceeds the desired size Signed-off-by: Shikhar Vashistha <[email protected]>

This commit introduces few fixes to file size checking and rotation including reopening the log file based of the request Signed-off-by: Shikhar Vashistha <[email protected]>

This commit adds functional test for file-rotation plugin Signed-off-by: Shikhar Vashistha <[email protected]>

Added file reopener struct to file-signal.h Signed-off-by: Shikhar Vashistha <[email protected]>

This commit adds reopening of a file via a flush signal Signed-off-by: Shikhar Vashistha <[email protected]>

This commit adds the functionality to reopen the destination file via reopener Signed-off-by: Shikhar Vashistha <[email protected]>

modules/file-rotation/file-rotation.c

modules/file-rotation/file-rotation.h

MrAnno · 2022-09-15T15:45:43Z

modules/file-rotation/file-rotation.c

+
+      g_free(new_filename);
+
+      self->number_of_time_rotated++;


As I see you've started working on the rotate() option. The implementation of this option is not trivial: we need to check already existing files and take actions based on what we found in the directory: rename existing 1, 2, 3-suffixed files so that we can use the "1" prefix for the currently rotated file, delete the file that falls out of the rotate(N) range, etc.

An in-memory counter is not enough here, as we'd accidentally override existing files after restarting syslog-ng.

(I'm more than happy if you're willing to work on it, but I'd like to mention that it's not a requirement for the project.)

Have implemented here kindly have a look

Thank you, it is starting to take shape. number_of_time_rotated is still a memory-only value, this feature should work properly between restarts too, which requires checking already existing rotated files on the disk.

I think this will take care of that issue.

This commit introduces a new option to set number of file rotations possible and few validation checks Signed-off-by: Shikhar Vashistha <[email protected]>

shikharvashistha · 2022-09-20T01:36:33Z

Hi @MrAnno, can we consider winding up the project?

MrAnno

Thank you.

Please consider fixing the above additional review notes (or reverting back to the non-rotate() version of the PR.

After that, please open a pull request against syslog-ng/syslog-ng.
Please don't forget to read our contribution guide, especially the section about pull requests:
https://github.com/syslog-ng/syslog-ng/blob/master/CONTRIBUTING.md#pull-requests

A few rounds of review will be done there too.
That may slip past the project timeline, but I hope you will still be available from time to time.

modules/affile/logproto-file-writer.c

MrAnno · 2022-09-20T10:53:46Z

modules/file-rotation/file-rotation.c

+
+      g_free(new_filename);
+
+      self->number_of_time_rotated++;


Thank you, it is starting to take shape. number_of_time_rotated is still a memory-only value, this feature should work properly between restarts too, which requires checking already existing rotated files on the disk.

This commit introduces checking file everytime on disk Signed-off-by: Shikhar Vashistha <[email protected]>

shikharvashistha · 2022-09-20T12:27:05Z

Thank you.

Please consider fixing the above additional review notes (or reverting back to the non-rotate() version of the PR.

After that, please open a pull request against syslog-ng/syslog-ng. Please don't forget to read our contribution guide, especially the section about pull requests: https://github.com/syslog-ng/syslog-ng/blob/master/CONTRIBUTING.md#pull-requests

A few rounds of review will be done there too. That may slip past the project timeline, but I hope you will still be available from time to time.

Yeah I'll be available for the review

file-rotation: set_date_format

0226a54

This commit introduces functionality for setting up date format based of last_rotation_time Signed-off-by: Shikhar Vashistha <[email protected]>

shikharvashistha force-pushed the file-rotation branch from 8de05cb to 0226a54 Compare August 28, 2022 06:31

file-rotation: file size checking, rename the file

5b0cd3e

This commit includes the file size checking and renaming if it exceeds the desired size Signed-off-by: Shikhar Vashistha <[email protected]>

shikharvashistha force-pushed the file-rotation branch from 49db888 to 5b0cd3e Compare August 28, 2022 11:09

file-rotation: reopen log file & fixes

6ca1d00

This commit introduces few fixes to file size checking and rotation including reopening the log file based of the request Signed-off-by: Shikhar Vashistha <[email protected]>

shikharvashistha changed the title ~~File size checking~~ File size checking & log-file reopening Aug 29, 2022

shikharvashistha force-pushed the file-rotation branch 3 times, most recently from 79dac81 to ccd0062 Compare September 3, 2022 04:01

file-rotation: Added functional test

091baf6

This commit adds functional test for file-rotation plugin Signed-off-by: Shikhar Vashistha <[email protected]>

shikharvashistha force-pushed the file-rotation branch from ccd0062 to 091baf6 Compare September 3, 2022 05:04

shikharvashistha added 3 commits September 14, 2022 16:18

file-signals: add file reopener

ab944b6

Added file reopener struct to file-signal.h Signed-off-by: Shikhar Vashistha <[email protected]>

affile: allow reopening the given file from the flush signal

7b24998

This commit adds reopening of a file via a flush signal Signed-off-by: Shikhar Vashistha <[email protected]>

file-rotation: request file reopening from the destination

fdd42ce

This commit adds the functionality to reopen the destination file via reopener Signed-off-by: Shikhar Vashistha <[email protected]>

shikharvashistha force-pushed the file-rotation branch from 2b4530d to fdd42ce Compare September 14, 2022 16:23

MrAnno reviewed Sep 14, 2022

View reviewed changes

shikharvashistha requested a review from MrAnno September 15, 2022 05:40

shikharvashistha force-pushed the file-rotation branch 2 times, most recently from e7f38b7 to cf12e49 Compare September 15, 2022 15:18

MrAnno reviewed Sep 15, 2022

View reviewed changes

shikharvashistha force-pushed the file-rotation branch from cf12e49 to 581d2c2 Compare September 15, 2022 16:04

file-rotation: file_rotation_set_number_of_file_rotatations

51bb5fe

This commit introduces a new option to set number of file rotations possible and few validation checks Signed-off-by: Shikhar Vashistha <[email protected]>

shikharvashistha force-pushed the file-rotation branch from 581d2c2 to 51bb5fe Compare September 15, 2022 17:29

shikharvashistha requested a review from MrAnno September 16, 2022 08:05

MrAnno reviewed Sep 20, 2022

View reviewed changes

file-rotation: Added checking file

c675ea8

This commit introduces checking file everytime on disk Signed-off-by: Shikhar Vashistha <[email protected]>

shikharvashistha mentioned this pull request Sep 20, 2022

GSoC'22: Log File Rotation syslog-ng/syslog-ng#4145

Closed

MrAnno closed this Sep 20, 2022

Conversation

shikharvashistha commented Aug 28, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Aug 28, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

MrAnno Sep 15, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

shikharvashistha Sep 15, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

MrAnno Sep 20, 2022

Choose a reason for hiding this comment

Uh oh!

shikharvashistha Sep 20, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

shikharvashistha commented Sep 20, 2022

Uh oh!

MrAnno left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

MrAnno Sep 20, 2022

Choose a reason for hiding this comment

Uh oh!

shikharvashistha commented Sep 20, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

shikharvashistha commented Aug 28, 2022 •

edited

Loading

MrAnno Sep 15, 2022 •

edited

Loading

shikharvashistha Sep 15, 2022 •

edited

Loading

shikharvashistha Sep 20, 2022 •

edited

Loading

MrAnno left a comment •

edited

Loading