File destination flush signal by shikharvashistha · Pull Request #17 · MrAnno/syslog-ng

shikharvashistha · 2022-07-29T19:30:07Z

This pull introduces file rotation mechanism to syslog-ng

github-actions · 2022-07-29T19:30:20Z

No news file has been detected. Please write one, if applicable.

modules/file-rotation/file-rotation-parser.c

modules/file-rotation/file-rotation.c

modules/file-rotation/file-rotation.h

modules/file-rotation/tests/test_file_rotation.c

modules/affile/logproto-file-writer.c

modules/affile/logproto-file-writer.h

MrAnno · 2022-08-02T19:28:21Z

Our commit message template is the following:

modulename: short description of the commit

optional longer description

Signed-off-by: Name <email>

Marking bug/fix/chore is a good practice, but we start with the module's name instead.
In our case, affile and file-rotation.

shikharvashistha · 2022-08-04T13:45:22Z

Hi, @MrAnno, I'm unable to see these conflicts locally don't know why these are there.

MrAnno · 2022-08-04T13:59:03Z

I can't review this. Please fix the git history.
I'm happy to help with git rebase or anything, we can talk about it on Gitter.

MrAnno

I've also clicked "unresolve" on 3 of my previous notes. Those notes try to explain why this does not work.

Also, I can't compile the current version of this branch, file-signals.h is missing from this patchset, it is probably a rebase issue.

modules/file-rotation/file-rotation-parser.c

shikharvashistha · 2022-08-07T10:09:48Z

I've also clicked "unresolve" on 3 of my previous notes. Those notes try to explain why this does not work.

Also, I can't compile the current version of this branch, file-signals.h is missing from this patchset, it is probably a rebase issue.

Yeah because it didn't got commited used git add -u

modules/file-rotation/file-rotation.c

modules/affile/file-opener.h

modules/affile/file-signals.h

modules/affile/logproto-file-writer.c

modules/affile/file-signals.h

modules/affile/logproto-file-writer.c

modules/file-rotation/file-rotation.h

This commit adds signal to the file destination involving passing AFFileDestDriver's instance signal slot connector to the LogProtoFileWriter Signed-off-by: Shikhar Vashistha <[email protected]>

This commit introduces new option to set interval for log rotation Signed-off-by: Shikhar Vashistha <[email protected]>

This commit introduces the controller function for updating/set log rotation interval & Adds support code for connecting AFFileDestDriver plugin's signal_slot_connector to our plugin Signed-off-by: Shikhar Vashistha <[email protected]>

…in test for set_interval This commit updates the location of plugin's request payload and the SIGNAL which is required to be emitted Signed-off-by: Shikhar Vashistha <[email protected]>

MrAnno

The proto constructor signature change hasn't been followed in our unit tests, please fix them there as well.

https://github.com/MrAnno/syslog-ng/runs/8036247829?check_suite_focus=true

modules/affile/logproto-file-writer.c

modules/file-rotation/file-rotation.c

modules/file-rotation/file-rotation-grammar.ym

MrAnno · 2022-08-27T16:42:21Z

There is one remaining CMake build issue in the CI:

[ 80%] Building C object syslog-ng-ctl/CMakeFiles/syslog-ng-ctl.dir/syslog-ng-ctl.c.o
/__w/syslog-ng/syslog-ng/modules/file-rotation/file-rotation.c:25:10: fatal error: 'modules/affile/file-signals.h' file not found
#include "modules/affile/file-signals.h"
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

You can fix this by adding the following to modules/file-rotation/CMakeLists.txt:

--- a/modules/file-rotation/CMakeLists.txt
+++ b/modules/file-rotation/CMakeLists.txt
@@ -15,6 +15,7 @@ add_module(
   TARGET file_rotation
   GRAMMAR file-rotation-grammar
   SOURCES ${FILE_ROTATION_SOURCES}
+  INCLUDES ${PROJECT_SOURCE_DIR}
 )

shikharvashistha · 2022-08-27T17:52:23Z

There is one remaining CMake build issue in the CI:

[ 80%] Building C object syslog-ng-ctl/CMakeFiles/syslog-ng-ctl.dir/syslog-ng-ctl.c.o
/__w/syslog-ng/syslog-ng/modules/file-rotation/file-rotation.c:25:10: fatal error: 'modules/affile/file-signals.h' file not found
#include "modules/affile/file-signals.h"
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

You can fix this by adding the following to modules/file-rotation/CMakeLists.txt:

--- a/modules/file-rotation/CMakeLists.txt
+++ b/modules/file-rotation/CMakeLists.txt
@@ -15,6 +15,7 @@ add_module(
   TARGET file_rotation
   GRAMMAR file-rotation-grammar
   SOURCES ${FILE_ROTATION_SOURCES}
+  INCLUDES ${PROJECT_SOURCE_DIR}
 )

Yeah I've added it to CMakeLists.txt

This commit assigns the AFFileDestDriver signal_slot_connector to the logproto's file writer struct Signed-off-by: Shikhar Vashistha <[email protected]>

File destination flush signal

MrAnno force-pushed the file-rotation-skeleton branch from 69d0df2 to ca67f18 Compare August 2, 2022 18:21

MrAnno force-pushed the file-rotation-skeleton branch from 9ed269a to 1f3568f Compare August 2, 2022 18:27

MrAnno reviewed Aug 2, 2022

View reviewed changes

shikharvashistha force-pushed the file-rotation-skeleton branch 2 times, most recently from fec0a5a to d8f24cd Compare August 4, 2022 13:41

shikharvashistha requested a review from MrAnno August 4, 2022 13:42

MrAnno removed their request for review August 4, 2022 13:59

shikharvashistha force-pushed the file-rotation-skeleton branch from d8f24cd to 55caac8 Compare August 5, 2022 07:20

MrAnno reviewed Aug 5, 2022

View reviewed changes

modules/file-rotation/file-rotation-parser.c Outdated Show resolved Hide resolved

MrAnno reviewed Aug 8, 2022

View reviewed changes

modules/file-rotation/file-rotation.c Outdated Show resolved Hide resolved

shikharvashistha force-pushed the file-rotation-skeleton branch from 5f73c4f to dcfa2d3 Compare August 9, 2022 06:05

shikharvashistha requested a review from MrAnno August 15, 2022 05:39

MrAnno reviewed Aug 19, 2022

View reviewed changes

modules/affile/file-opener.h Outdated Show resolved Hide resolved

MrAnno reviewed Aug 19, 2022

View reviewed changes

modules/affile/file-opener.h Outdated Show resolved Hide resolved

MrAnno mentioned this pull request Aug 19, 2022

Rotate log files based on size syslog-ng/syslog-ng#2964

Closed

MrAnno reviewed Aug 23, 2022

View reviewed changes

MrAnno changed the title ~~feat: file rotation plugin~~ File destination flush signal Aug 23, 2022

shikharvashistha force-pushed the file-rotation-skeleton branch 3 times, most recently from 887c2aa to 17b7c82 Compare August 26, 2022 12:03

shikharvashistha added 4 commits August 26, 2022 12:07

affile: Integrated signal to the file destination

8723548

This commit adds signal to the file destination involving passing AFFileDestDriver's instance signal slot connector to the LogProtoFileWriter Signed-off-by: Shikhar Vashistha <[email protected]>

file-rotation: Added new interval option to file rotation plugin

ed12d22

This commit introduces new option to set interval for log rotation Signed-off-by: Shikhar Vashistha <[email protected]>

affile: Seperated FileFlushData & SIGNAL to a new file & Updated plug…

a58e95b

…in test for set_interval This commit updates the location of plugin's request payload and the SIGNAL which is required to be emitted Signed-off-by: Shikhar Vashistha <[email protected]>

shikharvashistha force-pushed the file-rotation-skeleton branch from 17b7c82 to a102b1c Compare August 26, 2022 12:07

shikharvashistha force-pushed the file-rotation-skeleton branch from a102b1c to 6d5bb67 Compare August 26, 2022 12:15

MrAnno reviewed Aug 26, 2022

View reviewed changes

modules/affile/logproto-file-writer.c Outdated Show resolved Hide resolved

modules/file-rotation/file-rotation.c Outdated Show resolved Hide resolved

shikharvashistha force-pushed the file-rotation-skeleton branch 2 times, most recently from 9983d33 to f4dab3f Compare August 27, 2022 07:10

MrAnno reviewed Aug 27, 2022

View reviewed changes

modules/file-rotation/file-rotation-grammar.ym Outdated Show resolved Hide resolved

shikharvashistha force-pushed the file-rotation-skeleton branch 2 times, most recently from e975796 to 5803475 Compare August 27, 2022 17:51

shikharvashistha force-pushed the file-rotation-skeleton branch from 5803475 to 0ced24a Compare August 27, 2022 18:12

affile: Assigned AFFile's signal_slot_connetor to logproto's

8f37eaa

This commit assigns the AFFileDestDriver signal_slot_connector to the logproto's file writer struct Signed-off-by: Shikhar Vashistha <[email protected]>

shikharvashistha force-pushed the file-rotation-skeleton branch from 0ced24a to 8f37eaa Compare August 27, 2022 18:34

MrAnno approved these changes Aug 27, 2022

View reviewed changes

MrAnno merged commit f8f2e1e into MrAnno:file-rotation-skeleton Aug 27, 2022

MrAnno added a commit that referenced this pull request Aug 27, 2022

Merge pull request #17 from shikharvashistha/file-rotation-skeleton

726959e

File destination flush signal

MrAnno added a commit that referenced this pull request Aug 27, 2022

Merge pull request #17 from shikharvashistha/file-rotation-skeleton

a1ad736

File destination flush signal

shikharvashistha mentioned this pull request Sep 20, 2022

GSoC'22: Log File Rotation syslog-ng/syslog-ng#4145

Closed

Conversation

shikharvashistha commented Jul 29, 2022

Uh oh!

github-actions bot commented Jul 29, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

MrAnno commented Aug 2, 2022

Uh oh!

shikharvashistha commented Aug 4, 2022

Uh oh!

MrAnno commented Aug 4, 2022

Uh oh!

MrAnno left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

shikharvashistha commented Aug 7, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

MrAnno left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

MrAnno commented Aug 27, 2022

Uh oh!

shikharvashistha commented Aug 27, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants