lib/l10n/intl_it.arb (1)

274-281: Critical: Remove duplicate localization keys

The following keys are defined twice in this file, which will cause runtime errors:

• proofOfWork (lines 279 and 629)
• holdInvoiceCltvDelta (lines 281 and 628)
• maxOrderAmount (lines 274 and 637)
• minOrderAmount (lines 275 and 638)

The duplicates appear to be from the new About screen section. Please remove the duplicate entries from lines 627-629 and 637-638, keeping only the original definitions.

Also applies to: 627-629, 637-638

lib/features/settings/about_screen.dart (1)

71-72: Document the hardcoded default values

The hardcoded default values for APP_VERSION and GIT_COMMIT should be documented to explain their purpose. Consider adding a comment explaining that these are compile-time constants injected during the build process.

+  // These constants are injected at compile time via --dart-define flags
+  // Default values are provided for development builds
   const String appVersion = String.fromEnvironment('APP_VERSION', defaultValue: '1.0.0');
   const String gitCommit = String.fromEnvironment('GIT_COMMIT', defaultValue: 'add5b89d87674067d54c79ca01275856e45554a2');

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

Learnt from: CR
PR: MostroP2P/mobile#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-08T17:55:04.549Z
Learning: Applies to CLAUDE.md : Update documentation (CLAUDE.md) when making architectural changes

Learnt from: CR
PR: MostroP2P/mobile#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-08T17:55:04.549Z
Learning: Applies to test/mocks.dart : Mocks are generated using Mockito in `test/mocks.dart`

Learnt from: CR
PR: MostroP2P/mobile#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-08T17:55:04.549Z
Learning: Target zero `flutter analyze` issues

Learnt from: CR
PR: MostroP2P/mobile#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-08T17:55:04.549Z
Learning: Applies to **/*.dart : Use `const` constructors where possible

Learnt from: CR
PR: MostroP2P/mobile#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-08T17:55:04.549Z
Learning: Applies to **/*.dart : Remove unused imports and dependencies

Learnt from: CR
PR: MostroP2P/mobile#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-08T17:55:04.549Z
Learning: Applies to **/*.g.dart : Do not manually edit files ending with `.g.dart`

Learnt from: CR
PR: MostroP2P/mobile#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-08T17:55:04.549Z
Learning: Always maintain zero Flutter analyze issues

Learnt from: chebizarro
PR: MostroP2P/mobile#127
File: lib/data/models/cant_do.dart:10-27
Timestamp: 2025-07-08T05:40:47.527Z
Learning: In the CantDo model parsing in lib/data/models/cant_do.dart, the inconsistent key naming between 'cant_do' (top-level) and 'cant-do' (nested) is required by the protocol specification and should not be changed as it would break message parsing compatibility.

Learnt from: CR
PR: MostroP2P/mobile#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-08T17:55:04.549Z
Learning: Applies to lib/l10n/intl_{en,es,it}.arb : Add new localization keys to all three ARB files (en, es, it)

Learnt from: CR
PR: MostroP2P/mobile#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-08T17:55:04.549Z
Learning: Applies to lib/l10n/*.arb : Use proper ARB metadata for strings with parameters

Learnt from: CR
PR: MostroP2P/mobile#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-08T17:55:04.549Z
Learning: Test localization changes in all supported languages

Learnt from: CR
PR: MostroP2P/mobile#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-08T17:55:04.549Z
Learning: Applies to lib/l10n/intl_{en,es,it}.arb : Add new localization keys to all three ARB files (en, es, it)

Learnt from: CR
PR: MostroP2P/mobile#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-08T17:55:04.549Z
Learning: Applies to lib/l10n/*.arb : Use proper ARB metadata for strings with parameters

Learnt from: CR
PR: MostroP2P/mobile#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-08T17:55:04.549Z
Learning: Test localization changes in all supported languages

Learnt from: chebizarro
PR: MostroP2P/mobile#74
File: lib/services/mostro_service.dart:70-76
Timestamp: 2025-05-06T15:49:26.443Z
Learning: In the Mostro Mobile codebase, `eventStorageProvider` is exported from `package:mostro_mobile/shared/providers/mostro_service_provider.dart` and not from a separate `event_storage_provider.dart` file.

Learnt from: CR
PR: MostroP2P/mobile#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-08T17:55:04.549Z
Learning: Applies to lib/l10n/intl_{en,es,it}.arb : Add new localization keys to all three ARB files (en, es, it)

Learnt from: CR
PR: MostroP2P/mobile#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-08T17:55:04.549Z
Learning: Applies to lib/l10n/*.arb : Use proper ARB metadata for strings with parameters

lib/l10n/intl_es.arb (1)

619-621: Remove duplicate localization keys.

The static analysis correctly identifies duplicate keys. These keys already exist earlier in the file:

• holdInvoiceExpiration (line 619) - already exists around line 280
• holdInvoiceCltvDelta (line 620) - already exists around line 281
• invoiceExpirationWindow (line 621) - already exists around line 282
• maxOrderAmount (line 629) - already exists around line 274
• minOrderAmount (line 630) - already exists around line 275

Remove the duplicate entries:

-  "holdInvoiceExpiration": "Expiración de Factura de Retención",
-  "holdInvoiceCltvDelta": "Delta CLTV de Factura de Retención",
-  "invoiceExpirationWindow": "Ventana de Expiración de Factura",

-  "maxOrderAmount": "Cantidad Máxima de Orden",
-  "minOrderAmount": "Cantidad Mínima de Orden",

Also applies to: 629-630

lib/l10n/intl_en.arb (1)

587-589: Remove duplicate localization keys.

The static analysis correctly identifies duplicate keys. These keys already exist earlier in the file:

• holdInvoiceCltvDelta (line 587) - already exists around line 318
• invoiceExpirationWindow (line 588) - already exists around line 319
• proofOfWork (line 589) - already exists around line 316
• maxOrderAmount (line 597) - already exists around line 311
• minOrderAmount (line 598) - already exists around line 312

Remove the duplicate entries:

-  "holdInvoiceCltvDelta": "Hold Invoice CLTV Delta",
-  "invoiceExpirationWindow": "Invoice Expiration Window",
-  "proofOfWork": "Proof of Work",

-  "maxOrderAmount": "Maximum Order Amount",
-  "minOrderAmount": "Minimum Order Amount",

Also applies to: 597-598

lib/features/settings/about_screen.dart (1)

359-372: Fix duplicate label usage for LND section.

The localization key lndDaemonVersion is used both as a section header (line 360) and as a row label (line 370). The section header should use a more general label.

Consider adding a new localization key for the section header:

             // LND Daemon Section
             Text(
-              S.of(context)!.lndDaemonVersion,
+              'LND Information', // TODO: Add localization key
               style: const TextStyle(
                 color: AppTheme.activeColor,
                 fontSize: 16,
                 fontWeight: FontWeight.w600,
               ),
             ),

Then add the corresponding localization keys to all ARB files (en, es, it):

• "lndInformation": "LND Information" (English)
• "lndInformation": "Información LND" (Spanish)
• "lndInformation": "Informazioni LND" (Italian)

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

Learnt from: CR
PR: MostroP2P/mobile#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-08T17:55:04.549Z
Learning: Applies to CLAUDE.md : Update documentation (CLAUDE.md) when making architectural changes

Learnt from: CR
PR: MostroP2P/mobile#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-08T17:55:04.549Z
Learning: Applies to lib/**/*.dart : Use `S.of(context).yourKey` for all user-facing strings

Learnt from: chebizarro
PR: MostroP2P/mobile#127
File: lib/data/models/cant_do.dart:10-27
Timestamp: 2025-07-08T05:40:47.527Z
Learning: In the CantDo model parsing in lib/data/models/cant_do.dart, the inconsistent key naming between 'cant_do' (top-level) and 'cant-do' (nested) is required by the protocol specification and should not be changed as it would break message parsing compatibility.

Learnt from: CR
PR: MostroP2P/mobile#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-08T17:55:04.549Z
Learning: Applies to lib/l10n/intl_{en,es,it}.arb : Add new localization keys to all three ARB files (en, es, it)

Learnt from: CR
PR: MostroP2P/mobile#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-08T17:55:04.549Z
Learning: Applies to lib/l10n/*.arb : Use proper ARB metadata for strings with parameters

Learnt from: CR
PR: MostroP2P/mobile#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-08T17:55:04.549Z
Learning: Applies to lib/l10n/intl_{en,es,it}.arb : Add new localization keys to all three ARB files (en, es, it)

Learnt from: CR
PR: MostroP2P/mobile#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-08T17:55:04.549Z
Learning: Applies to lib/l10n/*.arb : Use proper ARB metadata for strings with parameters

Learnt from: CR
PR: MostroP2P/mobile#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-08T17:55:04.549Z
Learning: Test localization changes in all supported languages

Learnt from: CR
PR: MostroP2P/mobile#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-08T17:55:04.549Z
Learning: Applies to lib/l10n/intl_{en,es,it}.arb : Add new localization keys to all three ARB files (en, es, it)

lib/l10n/intl_es.arb (1)

619-619: Remove duplicate localization key.

The static analysis correctly identifies a duplicate key. The key "holdInvoiceExpiration" on line 619 already exists earlier in the file around line 280 as "holdInvoiceExpirationWindow". This appears to be a different key with similar purpose.

However, let me verify this is actually a duplicate by checking if this exact key exists elsewhere in the file.

#!/bin/bash
# Check for duplicate keys in the Spanish localization file
echo "Checking for duplicate keys in intl_es.arb..."
grep -n '"holdInvoiceExpiration"' lib/l10n/intl_es.arb
echo "---"
grep -n '"holdInvoiceCltvDelta"' lib/l10n/intl_es.arb  
echo "---"
grep -n '"invoiceExpirationWindow"' lib/l10n/intl_es.arb
echo "---"
grep -n '"maxOrderAmount"' lib/l10n/intl_es.arb
echo "---"
grep -n '"minOrderAmount"' lib/l10n/intl_es.arb

lib/l10n/intl_it.arb (1)

625-625: Remove duplicate localization key.

The static analysis correctly identifies a duplicate key at line 625. Based on the past review comments, this appears to be part of a pattern where keys like "proofOfWork" were duplicated in the new About Screen section.

#!/bin/bash
# Check for duplicate keys in the Italian localization file
echo "Checking for duplicate keys in intl_it.arb..."
grep -n '"holdInvoiceCltvDelta"' lib/l10n/intl_it.arb
echo "---"
grep -n '"invoiceExpirationWindow"' lib/l10n/intl_it.arb
echo "---"
grep -n '"proofOfWork"' lib/l10n/intl_it.arb
echo "---"
grep -n '"maxOrderAmount"' lib/l10n/intl_it.arb
echo "---"
grep -n '"minOrderAmount"' lib/l10n/intl_it.arb

lib/l10n/intl_en.arb (1)

585-585: Remove duplicate localization key.

The static analysis correctly identifies a duplicate key at line 585. Based on the past review comments, this appears to be part of a systematic issue where keys like "proofOfWork" were duplicated in the new About Screen section.

#!/bin/bash
# Check for all duplicate keys in the English localization file
echo "Checking for duplicate keys in intl_en.arb..."
grep -n '"holdInvoiceCltvDelta"' lib/l10n/intl_en.arb
echo "---"
grep -n '"invoiceExpirationWindow"' lib/l10n/intl_en.arb
echo "---"
grep -n '"proofOfWork"' lib/l10n/intl_en.arb
echo "---"
grep -n '"maxOrderAmount"' lib/l10n/intl_en.arb
echo "---"
grep -n '"minOrderAmount"' lib/l10n/intl_en.arb

lib/features/settings/about_screen.dart (1)

18-38: Load license text from the LICENSE file instead of hardcoding.

This issue was previously identified and remains unaddressed. The hardcoded license text should be loaded dynamically from the LICENSE file to ensure consistency.

lib/features/settings/about_screen.dart (1)

663-699: Simplify URL launching logic and improve error handling.

The current implementation has nested try-catch blocks that make the code harder to read. Consider simplifying the logic and using a more straightforward approach.

  Future<void> _launchUrl(String url, BuildContext context) async {
    try {
      final Uri uri = Uri.parse(url);
-
-      // Try different launch modes in order of preference
-      bool launched = false;
-
-      // First try with platformDefault (most compatible)
-      try {
-        await launchUrl(uri, mode: LaunchMode.platformDefault);
-        launched = true;
-      } catch (e) {
-        // If platformDefault fails, try externalApplication
-        try {
-          await launchUrl(uri, mode: LaunchMode.externalApplication);
-          launched = true;
-        } catch (e2) {
-          // If both fail, try inAppWebView as last resort
-          try {
-            await launchUrl(uri, mode: LaunchMode.inAppWebView);
-            launched = true;
-          } catch (e3) {
-            // All methods failed
-            launched = false;
-          }
-        }
-      }
-
-      if (!launched && context.mounted) {
-        _showErrorSnackBar(context, 'Cannot open link - no app available');
-      }
+      
+      final launchModes = [
+        LaunchMode.platformDefault,
+        LaunchMode.externalApplication,
+        LaunchMode.inAppWebView,
+      ];
+      
+      for (final mode in launchModes) {
+        try {
+          await launchUrl(uri, mode: mode);
+          return; // Success, exit early
+        } catch (e) {
+          // Continue to next mode
+        }
+      }
+      
+      // All launch modes failed
+      if (context.mounted) {
+        _showErrorSnackBar(context, S.of(context)!.cannotOpenLink);
+      }
    } catch (e) {
      if (context.mounted) {
-        _showErrorSnackBar(context, 'Failed to open link');
+        _showErrorSnackBar(context, S.of(context)!.failedToOpenLink);
      }
    }
  }

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

Learnt from: CR
PR: MostroP2P/mobile#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-08T17:55:04.549Z
Learning: Applies to lib/**/*.dart : Use `S.of(context).yourKey` for all user-facing strings

Learnt from: chebizarro
PR: MostroP2P/mobile#127
File: lib/data/models/cant_do.dart:10-27
Timestamp: 2025-07-08T05:40:47.527Z
Learning: In the CantDo model parsing in lib/data/models/cant_do.dart, the inconsistent key naming between 'cant_do' (top-level) and 'cant-do' (nested) is required by the protocol specification and should not be changed as it would break message parsing compatibility.

Learnt from: CR
PR: MostroP2P/mobile#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-08T17:55:04.549Z
Learning: Applies to lib/l10n/intl_{en,es,it}.arb : Add new localization keys to all three ARB files (en, es, it)

Learnt from: CR
PR: MostroP2P/mobile#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-08T17:55:04.549Z
Learning: Applies to lib/l10n/*.arb : Use proper ARB metadata for strings with parameters

Learnt from: CR
PR: MostroP2P/mobile#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-08T17:55:04.549Z
Learning: Applies to lib/l10n/intl_{en,es,it}.arb : Add new localization keys to all three ARB files (en, es, it)

Learnt from: CR
PR: MostroP2P/mobile#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-08T17:55:04.549Z
Learning: Applies to lib/l10n/*.arb : Use proper ARB metadata for strings with parameters

Learnt from: CR
PR: MostroP2P/mobile#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-08T17:55:04.549Z
Learning: Test localization changes in all supported languages

Learnt from: CR
PR: MostroP2P/mobile#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-08T17:55:04.549Z
Learning: Applies to lib/l10n/intl_{en,es,it}.arb : Add new localization keys to all three ARB files (en, es, it)

Learnt from: CR
PR: MostroP2P/mobile#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-08T17:55:04.549Z
Learning: Applies to lib/l10n/*.arb : Use proper ARB metadata for strings with parameters