Skip to content

Dismiss only reviews in status: CHANGES_REQUESTED#161

Merged
MorrisonCole merged 1 commit intoMorrisonCole:mainfrom
ui-valts-mazurs:fix/dismiss-only-changes-requested
Nov 17, 2020
Merged

Dismiss only reviews in status: CHANGES_REQUESTED#161
MorrisonCole merged 1 commit intoMorrisonCole:mainfrom
ui-valts-mazurs:fix/dismiss-only-changes-requested

Conversation

@ui-valts-mazurs
Copy link
Copy Markdown
Contributor

Fixes #155 - Error when trying to dismiss already dismissed review
Fixes also the case when the action tried to dismiss reviews in state COMMENTED

@MorrisonCole
Copy link
Copy Markdown
Owner

Know a few users have been waiting for this but didn't have time to look so far so I'm super thankful for this PR @ui-valts-mazurs! <3

Copy link
Copy Markdown
Owner

@MorrisonCole MorrisonCole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Will get this released shortly 🙏

@MorrisonCole MorrisonCole merged commit e9c2dd1 into MorrisonCole:main Nov 17, 2020
@ui-valts-mazurs ui-valts-mazurs deleted the fix/dismiss-only-changes-requested branch November 17, 2020 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error when trying to dismiss already dismissed review

2 participants