You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit 6fe7d21
Browse filesBrowse the repository at this point in the historyBrowse files
fix(review): close round-2 fail-opens in the structured-payload path
Second adversarial review of the fixes found six more, three of them
letting a not-clean artifact score clean.
- pre-push-review.py: the rewritten fingerprint anchor still backtracked
exponentially. Removing the empty `\s*` alternative was necessary and
not sufficient: `={3,}` is self-ambiguous under the outer `*`, since a
run of `=` splits into chunks of size >= 3 exponentially many ways.
Measured on this tool's OWN `"=" * 60` report banner followed by any
non-matching text: 0.50s at 36, 4.01s at 42, 14.18s at 45. Replaced the
nested-quantifier regex with a line scan, which is linear by
construction and cannot reacquire the class from a future alternative
(0.36ms at 4000 `=`).
- review_payload.py: `find_fence_spans` defaults to
`swallow_unclosed=False`, which records only an unclosed fence's OPENER
line and leaves its interior live -- so the mask failed in both
directions. A truncated review quoting a CLEAN template scored clean,
and a quoted NOT_CLEAN payload minted an undischargeable finding.
check-pr-fully-clean.py already passes `swallow_unclosed=True` for this
reason; now so does this.
- check-pr-fully-clean.py: a payload's self-declared `reviewer` no longer
confers identity. It is body text the reviewer writes about itself, so
trusting it inverts #2308's invariant -- and it is load-bearing for
quorum: measured, two clean comments from the single `github-actions[bot]`
login whose payloads named different reviewers satisfied `--quorum 2`,
which shared/workflow/fully-clean.md makes the normal invocation.
- Drop the `review-json` payload alias. Nothing in the corpus emitted or
documented it, so it was a second verdict-bearing input spelling with no
producer.
- Drop the dead `(oid and oid.lower() == sha_lower)` term from
`is_sha_match`. It is read only where `oid` is falsy, so it can never
contribute -- while reading as having made formal-review OID matching
case-insensitive, which `is_match = (oid == sha)` is not.
- check-verdict-scan-parity.py: the corpus carried no `review-data`
fragment, so its zero for this change was a coverage statement -- the
same failure its own VOCAB comment records for #2668. Added a bounded
payload arm crossing placement (bare, fenced, unclosed fence, code span,
indented), which payload is authoritative, and verdict/findings
agreement. Yielded FIRST, deliberately: `--limit N` truncates the
generator and the full product is ~242k bodies, so an arm yielded last
sat at index 241,920 and was unreachable at any limit run by hand.
Verified: 516 + 50 + 12 tests pass; parity over 600 bodies (all 32 payload
bodies among them) reports 0 widened, 0 narrowed, negative control 157
divergences -> DISCRIMINATES; links, memory-file-size, skills, test-suite
coverage, reviewer-placeholder and hook-catalog checks green;
semantic-line-breaks clean across all four changed markdown files.
check("_reviewer_identity: reads reviewer from structured payload for bot login", checker._reviewer_identity(struct_clean, author="github-actions[bot]") =="Claude")
4094
+
# The payload's self-declared `reviewer` must NOT confer identity: it is
4095
+
# body text the reviewer writes about itself, and two comments from the one
4096
+
# `github-actions[bot]` login naming different reviewers otherwise satisfied
4097
+
# `--quorum 2`, which shared/workflow/fully-clean.md makes the normal
4098
+
# invocation. #2308: approval authority comes from author identity.
4099
+
check("_reviewer_identity: a payload's reviewer field does not override the login", checker._reviewer_identity(struct_clean, author="github-actions[bot]") =="github-actions[bot]")
4095
4100
check("_reviewer_identity: does not escalate unauthenticated member comment to bot identity", checker._reviewer_identity(struct_clean, author="human_member") =="human_member")
check("_reviewer_identity: reads reviewer from structured not-clean payload", checker._reviewer_identity(struct_not_clean, author="github-actions[bot]") =="Codex")
4146
+
check("_reviewer_identity: a not-clean payload's reviewer field does not override the login", checker._reviewer_identity(struct_not_clean, author="github-actions[bot]") =="github-actions[bot]")
0 commit comments