Use absolute paths for system framework references #1012
Conversation
|
Not sure what's up with CI. Tried running with my changes reverted but it's still failing: https://github.com/dimitarnestorov/MonitorControl/runs/6112268134?check_suite_focus=true |
|
@DimitarNestorov It seems to be an issue with the KeyboardShortcuts package, not your changes |
|
Also SimplyCoreAudio. I think there might be some changes here that somehow adversely affects packages. @DimitarNestorov - how should we proceed with this? |
|
Ok, disragard that. It seems everything fails now with the CI build as the other PR got stuck with the exact same issue #1025 |
waydabber
left a comment
waydabber
left a comment
There was a problem hiding this comment.
All right, I'll approve this one as the changes are entirely sensible, I don't know whats up with the CI build.
3 participants
This change is to improve developer experience. If you clone MonitorControl in a deep enough folder (e.g.
/tmp/1/2/3/4/5/6/7) those frameworks will appear as if they are missing.