feat: support entity-default for quotas#527
Merged
Mongey merged 8 commits intoMongey:mainfrom Mar 21, 2025
Merged
Conversation
petedannemann
commented
Mar 20, 2025
| module github.com/Mongey/terraform-provider-kafka | ||
|
|
||
| go 1.22.7 | ||
| go 1.23.0 |
Contributor
Author
There was a problem hiding this comment.
sarama bumped the go version so this was required https://github.com/IBM/sarama/blob/d6ca80a198c4fbc467c67f7430182eda6881b12c/go.mod#L3
…nemann/terraform-provider-kafka into feat/support-defaults-for-quotas
Mongey
approved these changes
Mar 21, 2025
Owner
|
thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This leverages what was started with #267 but addresses feedback around allowing
entity_nameto be omitted to create the entity-default quota. Additionally, this brings in a fix from Sarama that was required to get this to actually work. This fix has not been released with a new tag yet, so if preferable we could wait until then before releasing this feature