Skip to content

fixes#147

Merged
ljleb merged 6 commits into
mainfrom
fixes
Aug 18, 2023
Merged

fixes#147
ljleb merged 6 commits into
mainfrom
fixes

Conversation

@ljleb

@ljleb ljleb commented Aug 18, 2023

Copy link
Copy Markdown
Contributor
  • correctly load workflows from png info
  • use global_state and patch RETURN_TYPES before each workflow for more reliable type checking
  • fix webui ModelPatcher proxy for newer version of comfyui

@ljleb

ljleb commented Aug 18, 2023

Copy link
Copy Markdown
Contributor Author

PNG info is actually broken with some larger workflows. I'll look into it, but I'm not sure we can do something about it. For example, this workflow (it's in the metadata of the image):

workflow

52944-425230810-1girl

@ljleb

ljleb commented Aug 18, 2023

Copy link
Copy Markdown
Contributor Author

Found a fix. The webui needs to fix their png info parsing with this regex instead:

\s*([\w ]+):\s*("(?:\\.|[^\\"])+"|[^,]*)(?:,|$)

https://github.com/AUTOMATIC1111/stable-diffusion-webui/blob/68f336bd994bed5442ad95bad6b6ad5564a5409a/modules/generation_parameters_copypaste.py#L12

We can patch this line from the extension for the time being.

@ljleb ljleb requested a review from PladsElsker August 18, 2023 15:59

@PladsElsker PladsElsker left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ljleb ljleb merged commit a332cfa into main Aug 18, 2023
@ljleb ljleb deleted the fixes branch August 18, 2023 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants