Plain text component language codes#1077
Merged
Thorinwasher merged 6 commits intoMockBukkit:v1.21from Aug 30, 2024
Merged
Conversation
thelooter
requested changes
Aug 21, 2024
4everTheOne
approved these changes
Aug 22, 2024
| @@ -0,0 +1,6886 @@ | |||
| { | |||
Contributor
There was a problem hiding this comment.
Where does this file come from? Is it available in paper?
Contributor
Author
There was a problem hiding this comment.
Generated by metaminer (legal grayzone), let me make a pr for that actually already done apparently
4everTheOne
approved these changes
Aug 22, 2024
thelooter
approved these changes
Aug 29, 2024
Thorinwasher
force-pushed
the
plain-text-component-language-codes
branch
from
5502951 to
8b26f10
Compare
|
willkroboth
added a commit
to CommandAPI/CommandAPI
that referenced
this pull request
Sep 23, 2024
Updated test toolkit's MockBukkit version to include MockBukkit/MockBukkit#1077, which allows accessing Minecraft Language codes. Moved utilities for creating mock argument parsers into ArgumentUtilities class. Made example project build script run maven tests, so the tests in the `automated-tests` and `automated-tests-shaded` example projects are run by GitHub Actions.
willkroboth
added a commit
to CommandAPI/CommandAPI
that referenced
this pull request
Oct 28, 2024
Updated test toolkit's MockBukkit version to include MockBukkit/MockBukkit#1077, which allows accessing Minecraft Language codes. Moved utilities for creating mock argument parsers into ArgumentUtilities class. Made example project build script run maven tests, so the tests in the `automated-tests` and `automated-tests-shaded` example projects are run by GitHub Actions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1040
I might need to add more tests to this. But I honestly don't understand how translatable components work(got one more test from willkroboth)Checklist
The following items should be checked before the pull request can be merged.