Conversation
There was a problem hiding this comment.
Thanks for working on that @maximearmstrong! I would suggest:
-
creating a Python package via IntelliJ named
scripts(so that the Python interpreter is automatically configured when opening the project for IntelliJ IDE users)
-
placing these files inside a directory named
mobility-database-harvesterormobility-database-harvest(it might increase clarity sinceacceptance/testsmay suggest that the script you provided is a test suite). -
passing the content of the credentials file used for the authentication to google storage services: locally the path to the said file is provided as an environment variable. However, in the CI process, we would be using the content of the said file instead of its path.
|
As discussed, I will provide some modifications in order to avoid passing the JSON credentials file as a Github secret. |
lionel-nj
left a comment
lionel-nj
left a comment
There was a problem hiding this comment.
Thanks @maximearmstrong
3 participants
Summary:
This PR adds the Python script and requirements to harvest the datasets latest versions URLs from the Mobility Database/archives. The file are under
acceptance/tests/.Expected behavior:
Same as before. This PR changes nothing to the behaviour of the canonical GTFS validator.
Please make sure these boxes are checked before submitting your pull request - thanks!
gradle testto make sure you didn't break anythingInclude screenshot(s) showing how this pull request works and fixes the issue(s)