Skip to content

feat: make report names user configurable via CLI args#852

Merged
lionel-nj merged 2 commits intomasterfrom
rename-reports
Apr 14, 2021
Merged

feat: make report names user configurable via CLI args#852
lionel-nj merged 2 commits intomasterfrom
rename-reports

Conversation

@lionel-nj
Copy link
Copy Markdown
Contributor

@lionel-nj lionel-nj commented Apr 14, 2021

Summary:

This PR provides support to override naming of report outputs.

Expected behavior:

Additional CLI args :

  • -v or --validation_report_name - the value given to this CLI args should include .json extension;
  • -e or system_errors_report_name - the value given to this CLI args should include .json extension.

If provided: the reports will be named as defined by the user, else a default value are used:

  • report.json for the validation report
  • system_errors.json for the error report

Please make sure these boxes are checked before submitting your pull request - thanks!

- extend unit tests
- update docs
@lionel-nj lionel-nj self-assigned this Apr 14, 2021
@lionel-nj lionel-nj mentioned this pull request Apr 14, 2021
4 tasks
@lionel-nj lionel-nj added this to the v2.1 milestone Apr 14, 2021
Copy link
Copy Markdown
Member

@barbeau barbeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. One comment in-line, feel free to merge after you review it.

@lionel-nj lionel-nj merged commit 624923e into master Apr 14, 2021
@lionel-nj lionel-nj deleted the rename-reports branch April 14, 2021 18:30
@lionel-nj
Copy link
Copy Markdown
Contributor Author

Thanks for reviewing @barbeau

@lionel-nj lionel-nj linked an issue Apr 15, 2021 that may be closed by this pull request
@lionel-nj lionel-nj mentioned this pull request Apr 20, 2021
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rename validation report

2 participants