Skip to content

docs: Align SeverityLevel Javadocs with RULES.md#764

Merged
lionel-nj merged 1 commit intomasterfrom
clarify-severity
Feb 22, 2021
Merged

docs: Align SeverityLevel Javadocs with RULES.md#764
lionel-nj merged 1 commit intomasterfrom
clarify-severity

Conversation

@barbeau
Copy link
Copy Markdown
Member

@barbeau barbeau commented Feb 19, 2021

Summary:

Closes #762

Align SeverityLevel docs with RULES.md . Also fix a typo.

Expected behavior:

Definition of ERRORS, WARNINGS, and INFO in SeverityLevel Javadocs should match what we've implemented in code (see #726) and the documentation in RULES.md.

Please make sure these boxes are checked before submitting your pull request - thanks!

@barbeau barbeau requested a review from lionel-nj February 19, 2021 21:35
Copy link
Copy Markdown
Contributor

@lionel-nj lionel-nj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @barbeau!

@lionel-nj lionel-nj merged commit ce4a41e into master Feb 22, 2021
@lionel-nj lionel-nj deleted the clarify-severity branch February 22, 2021 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update notice severity definition in code

2 participants