feat: Split FieldParsingError into different classes#756
Merged
barbeau merged 2 commits intoMobilityData:masterfrom Feb 18, 2021
Merged
feat: Split FieldParsingError into different classes#756barbeau merged 2 commits intoMobilityData:masterfrom
barbeau merged 2 commits intoMobilityData:masterfrom
Conversation
Format requirements for different fields are different, so that probably does not make sense to group them all at the same error class. Separate error classes may be placed in different sections of a validation report that add details on the expected format. Users of GTFS Validator may want to reduce the severity of certain errors, e.g., validation of URLs and phone numbers.
Collaborator
Author
|
@barbeau @lionel-nj |
lionel-nj
suggested changes
Feb 18, 2021
Contributor
lionel-nj
left a comment
lionel-nj
left a comment
There was a problem hiding this comment.
Great idea! That will clarify the validation reports. Just one comment inline. Thanks @aababilov!
core/src/test/java/org/mobilitydata/gtfsvalidator/parsing/RowParserTest.java
Outdated
Show resolved
Hide resolved
barbeau
suggested changes
Feb 18, 2021
Member
barbeau
left a comment
barbeau
left a comment
There was a problem hiding this comment.
Thanks @aababilov! I agree that this is a good idea. Some comments in-line.
core/src/test/java/org/mobilitydata/gtfsvalidator/parsing/RowParserTest.java
Outdated
Show resolved
Hide resolved
core/src/main/java/org/mobilitydata/gtfsvalidator/notice/InvalidColorNotice.java
Show resolved
Hide resolved
core/src/main/java/org/mobilitydata/gtfsvalidator/notice/InvalidEmailNotice.java
Outdated
Show resolved
Hide resolved
core/src/main/java/org/mobilitydata/gtfsvalidator/notice/InvalidTimeNotice.java
Outdated
Show resolved
Hide resolved
core/src/main/java/org/mobilitydata/gtfsvalidator/notice/NonAsciiOrNonPrintableCharNotice.java
Outdated
Show resolved
Hide resolved
core/src/main/java/org/mobilitydata/gtfsvalidator/parsing/RowParser.java
Outdated
Show resolved
Hide resolved
Collaborator
Author
|
I am glad that you liked that idea! |
Collaborator
Author
|
Thanks for the review! |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Format requirements for different fields are different, so that probably
does not make sense to group them all at the same error class.
Separate error classes may be placed in different sections of a
validation report that add details on the expected format.
Users of GTFS Validator may want to reduce the severity of certain
errors, e.g., validation of URLs and phone numbers.