feat: Validate presence of location_type and the type of referenced location#500
Merged
barbeau merged 6 commits intoMobilityData:masterfrom Dec 9, 2020
Merged
Conversation
aababilov
force-pushed
the
location-type
branch
from
68b7031 to
06c05a9
Compare
aababilov
changed the title
This is the common behaviour for all setters that allows to chain them:
new GtfsStop.Builder().setCsvRowNumber(1).setStopId("s1").build()
aababilov
force-pushed
the
location-type
branch
2 times, most recently
from
e398738 to
5b69fd9
Compare
aababilov
force-pushed
the
location-type
branch
from
5b69fd9 to
6dcdf23
Compare
barbeau
reviewed
Dec 8, 2020
Member
barbeau
left a comment
barbeau
left a comment
There was a problem hiding this comment.
Thanks @aababilov! Looks good - a few comments in-line.
...rc/main/java/org/mobilitydata/gtfsvalidator/validator/LocationTypeSingleEntityValidator.java
Show resolved
Hide resolved
...est/java/org/mobilitydata/gtfsvalidator/validator/LocationTypeSingleEntityValidatorTest.java
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LocationWithoutParentStationNotice- A location that must haveparent_stationfield does not have it. The following location types must haveparent_station: entrance, generic node, boarding area.PlatformWithoutParentStationNotice- A platform has noparent_stationfield set. This is different from {@code LocationWithoutParentStationNotice} since it is less severe. Here we treatlocation_type=0withplatform_codeas a platform.StationWithParentStationNotice- A station hasparent_stationfield set.WrongParentLocationTypeNotice- incorrect type of the parent location (e.g., parent for a stop must be a station).