Merged
Conversation
# Conflicts: # .github/workflows/gradle.yml
Member
|
I enabled the ...so it seems like either a thread is hung somewhere or it's having an issue trying to unlock files. Here's the bottom of the log: |
Member
|
It looks like this is the last command to execute: Here's that task in So I assume this is where the problem is... |
Member
|
I've noticed that if I run locally with the ...even though I get a |
Member
|
When running the build locally with The exception I mentioned happens below this part of the log. |
|
Thks, lots of possibilities with adding Gradle debug option! |
Contributor
Author
|
The last line |
Member
|
Looks like: ...is definitely the problem - I opened a PR on my own repo to do further testing, and if I comment out the above task (in CUTR-at-USF@dcf971e) then the build passes on GitHub Actions: I'm guessing file deadlock when trying to copy into |
Member
|
Alright, I think the issue here is that it was trying to copy the I found a similar issue discussed here with Gradle and React: ...which says:
Related React issue is facebook/react-native#11696. I'm guessing . So, I've filtered out JAR files in this bundling in 7585983. task webjar(type: Jar) {
from(fileTree(dir: "build", exclude: "**/*.jar")) {
into "META-INF/resources"
}
}And, now the build passes on GitHub and Circle CI 🎉 :
Additional references:
|
added 3 commits
October 20, 2020 12:24
…test-reimplementation � Conflicts: � .github/workflows/gradle.yml
…-reimplementation
Contributor
Author
|
Thanks @barbeau (that was tricky..). I confirm, locally this works. Updating the github workflow to collect the artifacts. |
Contributor
Author
|
I also confirm that running the generated artifact produces the expected result. |
Contributor
Author
|
Todos:
|
Thks a lot!! |
added 6 commits
October 21, 2020 10:40
ghost
reviewed
Oct 21, 2020
application/cli-app/src/main/java/org/mobilitydata/gtfsvalidator/cli/Main.java
Outdated
Show resolved
Hide resolved
application/cli-app/src/main/java/org/mobilitydata/gtfsvalidator/cli/Main.java
Show resolved
Hide resolved
ghost
approved these changes
Oct 21, 2020
ghost
left a comment
ghost
left a comment
There was a problem hiding this comment.
Thks for the super good work, this is a great MVP/v0 of packaging the code in two different ways.
I will take it over from here
ghost
changed the title
ghost
merged commit
This was referenced Oct 22, 2020
4 tasks
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This PR provides support to develop a local web ui based on the existing gtfs validator using spring boot, and react/
Expected behavior:
./gradlew bootRun-> will start by default on server port 8080,To run the web app :
yarn startAdditional information:
This PR takes content from #365 and #413
This PR comes as replacement to the two aforementioned PRs. This PR was created in an attempt to solve a packaging bug. Therefore all changes from #365 were repatriated here in order to provide working code.
Please make sure these boxes are checked before submitting your pull request - thanks!
gradle testto make sure you didn't break anything