Implement #382 - Rework UI#381
Merged
lionel-nj merged 23 commits intopackage-web-app-as-jarfrom Sep 28, 2020
Merged
Conversation
added 16 commits
September 24, 2020 10:55
…I after drag and drop action
- create Constants.js file to store constants - create ApiRequest.js file to store functions used to call API
added 2 commits
September 25, 2020 13:34
- test controller - test service manager - add exception handling
lionel-nj
changed the base branch from
build-local-web-ui
to
package-web-app-as-jar
application/spring-boot-app/src/main/java/org/mobilitydata/gtfsvalidator/ServiceManager.java
Show resolved
Hide resolved
added 4 commits
September 28, 2020 09:59
- axios: http requests: - material-ui: progress circles
- Rename methods to be consistent with http requests - Add progress circle - Add support to clear HTML on drop of other configuration file
ghost
approved these changes
Sep 28, 2020
ghost
left a comment
ghost
left a comment
There was a problem hiding this comment.
Nice progress in a relatively short time, well done!
LGTM
lionel-nj
added a commit
that referenced
this pull request
Sep 29, 2020
* Add support to allow CORS * Add support to package web app as jar -add dependency on client module - add task to build jar in client module * Adapt GitHub workflow to generate .jar from spring boot application * Touch * Modify default port for server launch * Use relative default path to access validation report * Modify GitHub workflow to run checks on different branch * Reset hard coded path to validation report * Remove support for CORS since irrelevant now * Add configuration file to prevent generation of package-lock.json https://www.codementor.io/@johnkennedy/get-rid-of-that-npm-package-lock-json-e0bj7ai42 * Add unit test to check get mapping in spring boot application * Modify GitHub workflow - persist jar of web app - rework action names * Modify build.gradle files to adapt name of built artifacts * Prep next release * Bump version number * Add details for execution of bootJar command * Update README.md and RELEASE.md with instructions regarding web app * Update link to screenshot in documentation * Implement #382 - Rework UI (#381) * Rename file for clarity * Add dropzone elements into UI * Add support to render execution parameter configuration file within UI after drag and drop action * web client: Add support to review exec param config file * Implement builder pattern for DefaultConfig * Add dependency to beautify json files * Implement validation of GTFS archive * Remove 80% opacity on dropzone * Improve rendering of json content as table * Add support on client side to handle fee validation * Rename files according to conventions * Disable caching * Improve code modularity - create Constants.js file to store constants - create ApiRequest.js file to store functions used to call API * Server: Implement method to get path to report * Add eof line * Server side: add unit tests - test controller - test service manager - add exception handling * remove redundant time consuming test * Implement test of interface with jet * Add dependency on librairies: - axios: http requests: - material-ui: progress circles * - Leverage PostMapping in order to pass data to backend - Rename methods to be consistent with http requests - Add progress circle - Add support to clear HTML on drop of other configuration file * Additional unit tests * Comment test to be fixed * Add explicit call to method deleteTable to avoid no-unused-vars error * Change validation success message for clarity * Center display validation report report * Add console comment to inform success of application start - add link to http://localhost:8090 * Add option --beautify - define said option as "true" by default - add new key to option list - adapt mechanisms to retrieve value - define default value in default-execution-parameters.json - adapt tests - write additional tests to verify said implementation - Remove empty lines * Block interface interactions when validation process is running - add props.id to button for reference - add commands to release/hold buttons and dropzone * Modify GitHub workflow * Remove unused script * Make CircularProgress bigger - keep only 1 CircularProgress - change color to blue (Default) * Leverage JsonPretty to display examples of configuration files * Adjust CSS for table rendering json configuration file * Remove service worker usage * Update icons and page title * Update README.md * Update README.md * Remove unused components * Adjust import statements * Rename components * Rename components * Touch * Rename module client->react client * Rename module client->react client * Reset GitHub workflow * PR feedback - fix typos - improve documentation - update GitHub workflow * - update GitHub workflow
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This PR provides support to rework UI.
Expected behavior:
Please make sure these boxes are checked before submitting your pull request - thanks!
gradle testto make sure you didn't break anything