Implement #374 - Package spring boot application as .jar#377
Merged
lionel-nj merged 44 commits intobuild-local-web-uifrom Sep 29, 2020
Merged
Implement #374 - Package spring boot application as .jar#377lionel-nj merged 44 commits intobuild-local-web-uifrom
.jar#377lionel-nj merged 44 commits intobuild-local-web-uifrom
Conversation
added 2 commits
September 21, 2020 14:09
-add dependency on client module - add task to build jar in client module
Closed
3 tasks
- persist jar of web app - rework action names
* Rename file for clarity * Add dropzone elements into UI * Add support to render execution parameter configuration file within UI after drag and drop action * web client: Add support to review exec param config file * Implement builder pattern for DefaultConfig * Add dependency to beautify json files * Implement validation of GTFS archive * Remove 80% opacity on dropzone * Improve rendering of json content as table * Add support on client side to handle fee validation * Rename files according to conventions * Disable caching * Improve code modularity - create Constants.js file to store constants - create ApiRequest.js file to store functions used to call API * Server: Implement method to get path to report * Add eof line * Server side: add unit tests - test controller - test service manager - add exception handling * remove redundant time consuming test * Implement test of interface with jet * Add dependency on librairies: - axios: http requests: - material-ui: progress circles * - Leverage PostMapping in order to pass data to backend - Rename methods to be consistent with http requests - Add progress circle - Add support to clear HTML on drop of other configuration file * Additional unit tests * Comment test to be fixed
ghost
approved these changes
Sep 28, 2020
ghost
left a comment
ghost
left a comment
There was a problem hiding this comment.
LGTM. A few things to delete before merging
added 3 commits
September 29, 2020 09:05
- add link to http://localhost:8090
added 19 commits
September 29, 2020 11:24
- define said option as "true" by default - add new key to option list - adapt mechanisms to retrieve value - define default value in default-execution-parameters.json - adapt tests - write additional tests to verify said implementation - Remove empty lines
- add props.id to button for reference - add commands to release/hold buttons and dropzone
- keep only 1 CircularProgress - change color to blue (Default)
ghost
approved these changes
Sep 29, 2020
ghost
left a comment
ghost
left a comment
There was a problem hiding this comment.
Good to merge after integrating modifications from inline remarks
...mory-simple/src/main/java/org/mobilitydata/gtfsvalidator/db/InMemoryExecParamRepository.java
Outdated
Show resolved
Hide resolved
added 2 commits
September 29, 2020 17:20
- fix typos - improve documentation - update GitHub workflow
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This PR provides support to produce a
.jarfrom the spring boot applicationExpected behavior:
Artifact
spring-boot-app.jarshould be produced.GitHub
Please make sure these boxes are checked before submitting your pull request - thanks!
To run the executable:
java -jar spring-boot-app.jarGo to
localhost:8090the web ui should appear if it did not automatically pop-up when executing the.jargradle testto make sure you didn't break anything