Merged
Conversation
added 9 commits
November 29, 2019 15:32
-for Float and Integer types. Including range validation. -refactor String validation to expose only GTFS types to client code (id and text)
-add validation code -specified format HH:MM:SS or H:MM:SS -add unit testing of method
-add test to check for HHH:MM:SS rejection
# Conflicts: # src/main/java/org/mobilitydata/gtfsvalidator/conversion/CSVtoProtoConverter.java # src/main/java/org/mobilitydata/gtfsvalidator/rules/ValidationRules.java # src/main/java/org/mobilitydata/gtfsvalidator/util/GTFSTypeValidationUtils.java # src/test/java/org/mobilitydata/gtfsvalidator/util/GTFSTypeValidationUtilsTest.java
-required changes after merging PR #19 to master
-required changes after merging PR #19
# Conflicts: # src/main/java/org/mobilitydata/gtfsvalidator/util/GTFSTypeValidationUtils.java # src/test/java/org/mobilitydata/gtfsvalidator/util/GTFSTypeValidationUtilsTest.java
ghost
requested a review
from 
ghost
self-assigned this
ghost
changed the title
barbeau
approved these changes
Dec 5, 2019
Member
barbeau
left a comment
barbeau
left a comment
There was a problem hiding this comment.
LGTM
Looking at this, though, brought up some other questions about the data pipeline. I'll open an issue on that.
Author
Yes, please do ! :) |
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This PR adds parsing and validation of stops.txt as well as outputting it in protobuf binary format on disk
Expected behavior:
After executing Main.main(), a stops.pb file should exist in the output directory
Please make sure these boxes are checked before submitting your pull request - thanks!
gradle testto make sure you didn't break anything