feat: standardize empty value on report.json#2004
Merged
davidgamez merged 4 commits intomasterfrom Mar 6, 2025
Merged
Conversation
Contributor
📝 Acceptance Test Report📋 Summary✅ The rule acceptance has passed for commit 1af08e9 📊 Notices ComparisonNew Errors (0 out of 1824 datasets, ~0%) ✅No changes were detected due to the code change. Dropped Errors (1 out of 1824 datasets, ~0%) ✅Details of new errors due to code change, which is less than the provided threshold of 1%.
New Warnings (0 out of 1824 datasets, ~0%) ✅No changes were detected due to the code change. Dropped Warnings (0 out of 1824 datasets, ~0%) ✅No changes were detected due to the code change. 🛡️ Corruption Check0 out of 1824 sources (~0 %) are corrupted. ⏱️ Performance Assessment📈 Validation TimeAssess the performance in terms of seconds taken for the validation process.
📜 Memory Consumption
|
Contributor
📝 Acceptance Test Report📋 Summary✅ The rule acceptance has passed for commit 479d5e5 📊 Notices ComparisonNew Errors (0 out of 1824 datasets, ~0%) ✅No changes were detected due to the code change. Dropped Errors (1 out of 1824 datasets, ~0%) ✅Details of new errors due to code change, which is less than the provided threshold of 1%.
New Warnings (0 out of 1824 datasets, ~0%) ✅No changes were detected due to the code change. Dropped Warnings (1 out of 1824 datasets, ~0%) ✅Details of new errors due to code change, which is less than the provided threshold of 1%.
🛡️ Corruption Check0 out of 1824 sources (~0 %) are corrupted. ⏱️ Performance Assessment📈 Validation TimeAssess the performance in terms of seconds taken for the validation process.
|
| Metric | Dataset ID | Reference (s) | Latest (s) | Difference (s) |
|---|---|---|---|---|
| Average | -- | 470.76 MiB | 459.63 MiB | ⬇️-11.14 MiB |
| Median | -- | 335.92 MiB | 335.92 MiB | ⬇️0 bytes |
| Standard Deviation | -- | 801.32 MiB | 740.72 MiB | ⬇️-60.60 MiB |
| Minimum in References Reports | ro-vrancea-consiliul-judetean-vrancea-gtfs-1984 | 37.95 MiB | 37.95 MiB | ⬆️+3.02 KiB |
| Maximum in Reference Reports | gb-unknown-uk-aggregate-feed-gtfs-2014 | 10.66 GiB | 10.58 GiB | ⬇️-83.49 MiB |
| Minimum in Latest Reports | us-pennsylvania-monroe-county-transportation-authority-mcta-gtfs-523 | 363.92 MiB | 35.89 MiB | ⬇️-328.03 MiB |
| Maximum in Latest Reports | gb-unknown-uk-aggregate-feed-gtfs-2014 | 10.66 GiB | 10.58 GiB | ⬇️-83.49 MiB |
jcpitre
approved these changes
Mar 5, 2025
Contributor
📝 Acceptance Test Report📋 Summary✅ The rule acceptance has passed for commit 79d526f 📊 Notices ComparisonNew Errors (0 out of 1823 datasets, ~0%) ✅No changes were detected due to the code change. Dropped Errors (0 out of 1823 datasets, ~0%) ✅No changes were detected due to the code change. New Warnings (0 out of 1823 datasets, ~0%) ✅No changes were detected due to the code change. Dropped Warnings (0 out of 1823 datasets, ~0%) ✅No changes were detected due to the code change. 🛡️ Corruption Check0 out of 1823 sources (~0 %) are corrupted. ⏱️ Performance Assessment📈 Validation TimeAssess the performance in terms of seconds taken for the validation process.
📜 Memory Consumption
|
This reverts commit e4b8b7b.
Contributor
📝 Acceptance Test Report📋 Summary✅ The rule acceptance has passed for commit 1a5847b 📊 Notices ComparisonNew Errors (0 out of 1823 datasets, ~0%) ✅No changes were detected due to the code change. Dropped Errors (0 out of 1823 datasets, ~0%) ✅No changes were detected due to the code change. New Warnings (0 out of 1823 datasets, ~0%) ✅No changes were detected due to the code change. Dropped Warnings (0 out of 1823 datasets, ~0%) ✅No changes were detected due to the code change. 🛡️ Corruption Check0 out of 1823 sources (~0 %) are corrupted. ⏱️ Performance Assessment📈 Validation TimeAssess the performance in terms of seconds taken for the validation process.
📜 Memory Consumption
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This PR standardizes the empty strings by populating the values with
""instead ofN/Ain the generated report.json. Thereport.htmlwill still render"N/A"for empty values.Closes #2003
Expected behavior:
Empty values are actually empty in the generated
report.jsoninstead of"N/A".Please make sure these boxes are checked before submitting your pull request - thanks!
gradle testto make sure you didn't break anything