fix: python scripts failing in ubuntu-latest GitHub workflows#1944
Merged
davidgamez merged 5 commits intomasterfrom Jan 21, 2025
Merged
fix: python scripts failing in ubuntu-latest GitHub workflows#1944davidgamez merged 5 commits intomasterfrom
davidgamez merged 5 commits intomasterfrom
Conversation
Contributor
📝 Acceptance Test Report📋 Summary✅ The rule acceptance has passed for commit 5760d8c 📊 Notices ComparisonNew Errors (0 out of 1792 datasets, ~0%) ✅No changes were detected due to the code change. Dropped Errors (0 out of 1792 datasets, ~0%) ✅No changes were detected due to the code change. New Warnings (0 out of 1792 datasets, ~0%) ✅No changes were detected due to the code change. Dropped Warnings (0 out of 1792 datasets, ~0%) ✅No changes were detected due to the code change. 🛡️ Corruption Check0 out of 1792 sources (~0 %) are corrupted. ⏱️ Performance Assessment📈 Validation TimeAssess the performance in terms of seconds taken for the validation process.
📜 Memory Consumption
|
jcpitre
approved these changes
Jan 21, 2025
Contributor
jcpitre
left a comment
There was a problem hiding this comment.
Good change, using variables
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
As mentioned in #1938, the latest ubuntu runner has a difference default python version that is not compatible with some
oldpython dependencies. In this PR we are upgrading python dependencies in the scripts and also preparing the Github actions to bump up Python and Java versions by adding versions as a variable within the action.Fixes #1938
From our AI friend
This pull request includes several updates to the GitHub Actions workflows and dependencies in the project. The changes primarily focus on updating the environment configurations and dependency versions used in various workflows.
Workflow Environment Updates:
runs-onattribute fromubuntu-22.04toubuntu-latestin multiple jobs across various workflow files to ensure the use of the latest Ubuntu version. (.github/workflows/acceptance_test.yml, .github/workflows/docker.yml, .github/workflows/end_to_end.yml, .github/workflows/formatting.yml, .github/workflows/notice_migration_generation.yml, .github/workflows/package_installers.yml, .github/workflows/publish_assets.yml, .github/workflows/stg_web_client_merge.yml, .github/workflows/stg_web_svc_merge.yml, .github/workflows/web_client_pr.yml, .github/workflows/web_release.yml, .github/workflows/web_svc_pr.yml) [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14] [15] [16] [17] [18] [19] [20] [21] [22] [23] [24] [25] [26] [27] [28]Dependency Version Updates:
scripts/mobility-database-harvester/requirements.txtto newer versions for improved compatibility and performance.scripts/notice-migration-generator/requirements.txtto newer versions to ensure compatibility with the latest libraries.Specific Tool Setup Updates:
python_version,java_version, andjava_distributionto standardize the setup across various workflows. (.github/workflows/acceptance_test.yml, .github/workflows/docker.yml, .github/workflows/end_to_end.yml, .github/workflows/formatting.yml, .github/workflows/notice_migration_generation.yml, .github/workflows/package_installers.yml, .github/workflows/publish_assets.yml, .github/workflows/stg_web_client_merge.yml, .github/workflows/stg_web_svc_merge.yml, .github/workflows/web_client_pr.yml, .github/workflows/web_release.yml, .github/workflows/web_svc_pr.yml) [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14] [15] [16] [17] [18] [19] [20] [21] [22] [23] [24] [25] [26] [27] [28]These changes collectively improve the consistency, maintainability, and compatibility of the project's CI/CD workflows.
Expected behavior:
Explain and/or show screenshots for how you expect the pull request to work in your testing (in case other devices exhibit different behavior).
Please make sure these boxes are checked before submitting your pull request - thanks!
gradle testto make sure you didn't break anything