Skip to content

fix: Count appears as 1 for block even when no blocks exist#1802

Merged
qcdyx merged 1 commit intomasterfrom
1779-count-appears-as-1-for-block-even-when-no-blocks-exist
Aug 22, 2024
Merged

fix: Count appears as 1 for block even when no blocks exist#1802
qcdyx merged 1 commit intomasterfrom
1779-count-appears-as-1-for-block-even-when-no-blocks-exist

Conversation

@qcdyx
Copy link
Copy Markdown
Contributor

@qcdyx qcdyx commented Aug 21, 2024 •
edited
Loading

Summary:
Closes #1779

Expected behavior:
Email with screenshot sent to reviewers due to data privacy.

Please make sure these boxes are checked before submitting your pull request - thanks!

@qcdyx qcdyx linked an issue Aug 21, 2024 that may be closed by this pull request
Count appears as 1 for block even when no blocks exist #1779
Closed
@qcdyx qcdyx requested review from emmambd and jcpitre August 21, 2024 15:28
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Aug 21, 2024

📝 Acceptance Test Report

📋 Summary

✅ The rule acceptance has passed for commit aee1175
Download the full acceptance test report here (report will disappear after 90 days).

📊 Notices Comparison

New Errors (0 out of 1563 datasets, ~0%) ✅

No changes were detected due to the code change.

Dropped Errors (0 out of 1563 datasets, ~0%) ✅

No changes were detected due to the code change.

New Warnings (0 out of 1563 datasets, ~0%) ✅

No changes were detected due to the code change.

Dropped Warnings (0 out of 1563 datasets, ~0%) ✅

No changes were detected due to the code change.

🛡️ Corruption Check

0 out of 1563 sources (~0 %) are corrupted.

⏱️ Performance Assessment

📈 Validation Time

Assess the performance in terms of seconds taken for the validation process.

Time Metric Dataset ID Reference (s) Latest (s) Difference (s)
Average -- 3.89 4.12 ⬆️+0.23
Median -- 1.35 1.44 ⬆️+0.09
Standard Deviation -- 11.06 12.06 ⬆️+0.99
Minimum in References Reports us-oregon-high-desert-point-gtfs-636 0.48 0.61 ⬆️+0.12
Maximum in Reference Reports gb-unknown-uk-aggregate-feed-gtfs-2014 304.57 313.20 ⬆️+8.64
Minimum in Latest Reports us-california-city-of-wasco-gtfs-1788 0.75 0.55 ⬇️-0.19
Maximum in Latest Reports gb-unknown-uk-aggregate-feed-gtfs-2014 304.57 313.20 ⬆️+8.64

emmambd
emmambd reviewed Aug 22, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@emmambd emmambd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I tested with the original data and also tried removing the agencies in agency.txt to make sure the count shows as 0 for other entities - works as intended.

jcpitre
jcpitre approved these changes Aug 22, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@jcpitre jcpitre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Still somewhat intrigued as to why this happens with blocks but not with the other counts.

@qcdyx qcdyx merged commit b597b7c into master Aug 22, 2024
@qcdyx qcdyx deleted the 1779-count-appears-as-1-for-block-even-when-no-blocks-exist branch August 22, 2024 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@emmambd emmambd emmambd left review comments

@jcpitre jcpitre jcpitre approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Count appears as 1 for block even when no blocks exist

3 participants

@qcdyx @emmambd @jcpitre