Skip to content

fix: Display empty values for feed_start_date and feed_end_date if there's…#1798

Merged
qcdyx merged 5 commits intomasterfrom
1790-validation-report-summary-shows-unix-time-0-for-feed_start_date-and-feed_end_date-when-feed_infotxt-exists-with-empty-date-values
Aug 14, 2024
Merged

fix: Display empty values for feed_start_date and feed_end_date if there's…#1798
qcdyx merged 5 commits intomasterfrom
1790-validation-report-summary-shows-unix-time-0-for-feed_start_date-and-feed_end_date-when-feed_infotxt-exists-with-empty-date-values

Conversation

@qcdyx
Copy link
Copy Markdown
Contributor

@qcdyx qcdyx commented Aug 12, 2024 •
edited
Loading

Summary:
Closes #1790
image

Expected behavior:

Display empty values for feed_start_date and feed_end_date if there's no data for these two fields.

Please make sure these boxes are checked before submitting your pull request - thanks!

@qcdyx qcdyx linked an issue Aug 12, 2024 that may be closed by this pull request
Validation report summary shows Unix time 0 for feed_start_date and feed_end_date when feed_info.txt exists with empty date values #1790
Closed
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Aug 12, 2024

This contribution does not follow the conventions set by the Google Java style guide. Please run the following command line at the root of the project to fix formatting errors: ./gradlew goJF.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Aug 12, 2024

📝 Acceptance Test Report

📋 Summary

✅ The rule acceptance has passed for commit bc4f128
Download the full acceptance test report here (report will disappear after 90 days).

📊 Notices Comparison

New Errors (0 out of 1563 datasets, ~0%) ✅

No changes were detected due to the code change.

Dropped Errors (0 out of 1563 datasets, ~0%) ✅

No changes were detected due to the code change.

New Warnings (0 out of 1563 datasets, ~0%) ✅

No changes were detected due to the code change.

Dropped Warnings (0 out of 1563 datasets, ~0%) ✅

No changes were detected due to the code change.

🛡️ Corruption Check

13 out of 1576 sources (~1 %) are corrupted.
Dataset Ref Report Exists Ref Report Readable Latest Report Exists Latest Report Readable
it-puglia-mobilita-e-trasporti-molfetta-gtfs-1147 ✅ N/A ❌ N/A
it-regione-autonoma-della-sardegna-collegamenti-marittimi-grimaldi-gtfs-1192 ✅ N/A ❌ N/A
it-regione-autonoma-della-sardegna-collegamenti-marittimi-moby-gtfs-1048 ✅ N/A ❌ N/A
it-regione-autonoma-della-sardegna-collegamenti-marittimi-sardinia-ferries-gtfs-1050 ✅ N/A ❌ N/A
it-regione-autonoma-della-sardegna-collegamenti-marittimi-tirrenia-gtfs-1051 ✅ N/A ❌ N/A
mexico-jalisco-direccion-general-de-transporte-publico-de-puerto-vallarta-gtfs-2034 ✅ N/A ❌ N/A
mexico-oaxaca-secretaria-de-movilidad-oaxaca-gtfs-2033 ✅ N/A ❌ N/A
mx-jalisco-secretaria-de-movilidad-del-estado-de-jalisco-gtfs-1926 ✅ N/A ❌ N/A
pe-aeroexpreso-gtfs-1985 ✅ N/A ❌ N/A
tr-kocaeli-kocaeli-gtfs-1122 ✅ N/A ❌ N/A
us-arizona-national-park-service-gtfs-1905 ✅ N/A ❌ N/A
us-ohio-athens-public-transit-gtfs-4 ✅ N/A ❌ N/A
us-wisconsin-beloit-transit-gtfs-392 ✅ N/A ❌ N/A

⏱️ Performance Assessment

📈 Validation Time

Assess the performance in terms of seconds taken for the validation process.

Time Metric Dataset ID Reference (s) Latest (s) Difference (s)
Average -- 3.79 3.89 ⬆️+0.11
Median -- 1.35 1.43 ⬆️+0.08
Standard Deviation -- 10.59 10.85 ⬆️+0.26
Minimum in References Reports us-massachusetts-massachusetts-area-express-max-gtfs-431 0.51 0.54 ⬆️+0.03
Maximum in Reference Reports gb-unknown-uk-aggregate-feed-gtfs-2014 287.39 299.06 ⬆️+11.66
Minimum in Latest Reports us-massachusetts-massachusetts-area-express-max-gtfs-431 0.51 0.54 ⬆️+0.03
Maximum in Latest Reports gb-unknown-uk-aggregate-feed-gtfs-2014 287.39 299.06 ⬆️+11.66

@emmambd
Copy link
Copy Markdown
Contributor

emmambd commented Aug 14, 2024

@qcdyx Looks good on a QA side! Minor change: can we display "N/A" instead of an empty value? I realized it should match the other null behavior in the summary report (e.g agency email and URL, where if they're empty it returns N/A)

@qcdyx
Copy link
Copy Markdown
Contributor Author

qcdyx commented Aug 14, 2024 •
edited
Loading

@emmambd
image

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Aug 14, 2024

This contribution does not follow the conventions set by the Google Java style guide. Please run the following command line at the root of the project to fix formatting errors: ./gradlew goJF.

davidgamez
davidgamez reviewed Aug 14, 2024
View reviewed changes
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Aug 14, 2024

📝 Acceptance Test Report

📋 Summary

✅ The rule acceptance has passed for commit f9ed1df
Download the full acceptance test report here (report will disappear after 90 days).

📊 Notices Comparison

New Errors (0 out of 1563 datasets, ~0%) ✅

No changes were detected due to the code change.

Dropped Errors (0 out of 1563 datasets, ~0%) ✅

No changes were detected due to the code change.

New Warnings (0 out of 1563 datasets, ~0%) ✅

No changes were detected due to the code change.

Dropped Warnings (0 out of 1563 datasets, ~0%) ✅

No changes were detected due to the code change.

🛡️ Corruption Check

13 out of 1576 sources (~1 %) are corrupted.
Dataset Ref Report Exists Ref Report Readable Latest Report Exists Latest Report Readable
it-puglia-mobilita-e-trasporti-molfetta-gtfs-1147 ✅ N/A ❌ N/A
it-regione-autonoma-della-sardegna-collegamenti-marittimi-grimaldi-gtfs-1192 ✅ N/A ❌ N/A
it-regione-autonoma-della-sardegna-collegamenti-marittimi-moby-gtfs-1048 ✅ N/A ❌ N/A
it-regione-autonoma-della-sardegna-collegamenti-marittimi-sardinia-ferries-gtfs-1050 ✅ N/A ❌ N/A
it-regione-autonoma-della-sardegna-collegamenti-marittimi-tirrenia-gtfs-1051 ✅ N/A ❌ N/A
mexico-jalisco-direccion-general-de-transporte-publico-de-puerto-vallarta-gtfs-2034 ✅ N/A ❌ N/A
mexico-oaxaca-secretaria-de-movilidad-oaxaca-gtfs-2033 ✅ N/A ❌ N/A
mx-jalisco-secretaria-de-movilidad-del-estado-de-jalisco-gtfs-1926 ✅ N/A ❌ N/A
pe-aeroexpreso-gtfs-1985 ✅ N/A ❌ N/A
tr-kocaeli-kocaeli-gtfs-1122 ✅ N/A ❌ N/A
us-arizona-national-park-service-gtfs-1905 ✅ N/A ❌ N/A
us-ohio-athens-public-transit-gtfs-4 ✅ N/A ❌ N/A
us-wisconsin-beloit-transit-gtfs-392 ✅ N/A ❌ N/A

⏱️ Performance Assessment

📈 Validation Time

Assess the performance in terms of seconds taken for the validation process.

Time Metric Dataset ID Reference (s) Latest (s) Difference (s)
Average -- 3.81 3.89 ⬆️+0.08
Median -- 1.37 1.42 ⬆️+0.05
Standard Deviation -- 10.56 10.58 ⬆️+0.02
Minimum in References Reports ph-unknown-hm-transport-inc-and-robinsons-malls-gtfs-1105 0.49 0.61 ⬆️+0.12
Maximum in Reference Reports gb-unknown-uk-aggregate-feed-gtfs-2014 281.63 282.04 ⬆️+0.41
Minimum in Latest Reports ar-buenos-aires-subterraneos-de-buenos-aires-subte-gtfs-6 0.63 0.51 ⬇️-0.12
Maximum in Latest Reports gb-unknown-uk-aggregate-feed-gtfs-2014 281.63 282.04 ⬆️+0.41

@qcdyx qcdyx merged commit 2c81b7a into master Aug 14, 2024
@qcdyx qcdyx deleted the 1790-validation-report-summary-shows-unix-time-0-for-feed_start_date-and-feed_end_date-when-feed_infotxt-exists-with-empty-date-values branch August 14, 2024 16:36
@emmambd emmambd mentioned this pull request Sep 23, 2024
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@davidgamez davidgamez davidgamez approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Validation report summary shows Unix time 0 for feed_start_date and feed_end_date when feed_info.txt exists with empty date values

3 participants

@qcdyx @emmambd @davidgamez