Skip to content

fix: set transfer from and to stop ids as conditional required fields#1772

Merged
davidgamez merged 2 commits intomasterfrom
fix/transfer_from_to_ids
May 28, 2024
Merged

fix: set transfer from and to stop ids as conditional required fields#1772
davidgamez merged 2 commits intomasterfrom
fix/transfer_from_to_ids

Conversation

@davidgamez
Copy link
Copy Markdown
Member

@davidgamez davidgamez commented May 27, 2024 •
edited
Loading

Summary:

This PR aligns the validator response with the specification on the transfers.txt from and to stop IDs. The specification marks these fields as required for all records except those with a transfer_type of 4 or 5.

Closes #1621

Expected behavior:

For transfers.txt records with transfer types 4 and 5(in seat transfer types), the missing required field is not triggered.

Please make sure these boxes are checked before submitting your pull request - thanks!

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented May 27, 2024

✅ Rule acceptance tests passed.
New Errors: 0 out of 1523 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Errors: 0 out of 1523 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
New Warnings: 0 out of 1523 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Warnings: 0 out of 1523 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
0 out of 1523 sources (~0 %) are corrupted.
Commit: 7e6ac69
Download the full acceptance test report here (report will disappear after 90 days).
✅ Rule acceptance tests passed.

@davidgamez davidgamez marked this pull request as ready for review May 27, 2024 18:40
@davidgamez davidgamez mentioned this pull request May 27, 2024
Closed
qcdyx
qcdyx approved these changes May 27, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@qcdyx qcdyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented May 28, 2024

✅ Rule acceptance tests passed.
New Errors: 0 out of 1523 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Errors: 0 out of 1523 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
New Warnings: 0 out of 1523 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Warnings: 0 out of 1523 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
0 out of 1523 sources (~0 %) are corrupted.
Commit: cb45764
Download the full acceptance test report here (report will disappear after 90 days).
✅ Rule acceptance tests passed.

@davidgamez davidgamez merged commit d71580b into master May 28, 2024
@davidgamez davidgamez deleted the fix/transfer_from_to_ids branch May 28, 2024 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@qcdyx qcdyx qcdyx approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

from_stop_id and to_stop_id not required for transfer_type 4 & 5

2 participants

@davidgamez @qcdyx