Conversation
cka-y
added
do not merge
jcpitre
reviewed
May 16, 2024
| OP_SERVICE_ACCOUNT_TOKEN: ${{ secrets.OP_SERVICE_ACCOUNT_TOKEN }} | ||
| CREDENTIALS: "op://rbiv7rvkkrsdlpcrz3bmv7nmcu/ifkeehu5gzi7wy5ub5qvwkaire/credential" | ||
|
|
||
| - name: Send a notification to mobility-feed-api |
Contributor
There was a problem hiding this comment.
It would be useful to explain why we do this in web_release.yml and not, say, in publish_assets.yml. Something like:
# mobility_feed_api will use the deployed web service to update the validation reports
** This PR is already merged, so maybe we can slip this in a future PR?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This PR addresses part of issue #1746. It sends a repository dispatch notification to the mobility-feed-api with a type of either
gtfs-validator-update-stgorgtfs-validator-releasewhenever the GTFS Web Validator services are updated.Expected Behavior:
masterbranch, the staging web services are updated, triggering agtfs-validator-update-stgnotification.gtfs-validator-releasenotification.Please make sure these boxes are checked before submitting your pull request - thanks!
gradle testto make sure you didn't break anything