Skip to content

feat: documented the changes made in PR 1633#1748

Merged
qcdyx merged 2 commits intomasterfrom
1742-document-custom-user-agent-header
May 8, 2024
Merged

feat: documented the changes made in PR 1633#1748
qcdyx merged 2 commits intomasterfrom
1742-document-custom-user-agent-header

Conversation

@qcdyx
Copy link
Copy Markdown
Contributor

@qcdyx qcdyx commented May 8, 2024

Summary:

Closes #1742

Expected behavior:

User should be able to see documentation about user agent header in the "Using web-based validator" heading of the README

Please make sure these boxes are checked before submitting your pull request - thanks!

@qcdyx qcdyx linked an issue May 8, 2024 that may be closed by this pull request
@qcdyx qcdyx requested a review from emmambd May 8, 2024 15:16
Copy link
Copy Markdown
Member

@davidgamez davidgamez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Copy Markdown
Contributor

@emmambd emmambd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@qcdyx Can we include the actual user agent string in the docs?

@qcdyx
Copy link
Copy Markdown
Contributor Author

qcdyx commented May 8, 2024

@qcdyx Can we include the actual user agent string in the docs?

@emmambd It's a good idea! Done!

@qcdyx qcdyx merged commit 0d13c65 into master May 8, 2024
@qcdyx qcdyx deleted the 1742-document-custom-user-agent-header branch May 8, 2024 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Document custom user-agent header

3 participants