feat: Changed notice migration generation. Added zip file to release.#1736
Merged
davidgamez merged 4 commits intomasterfrom Apr 9, 2024
Merged
Conversation
Contributor
|
✅ Rule acceptance tests passed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Closes #1719
This issue has 2 parts:
The new process is:
Expected behavior:
Follow the new section
2. Update NOTICE_MIGRATION.md filein docs/RELEASE.md.After running the github action, a new PR should have been created with the notice migration data for the specified release.
For the upload zip installers task , create a fake draft release and verify that the 3 installer zip files are present as release artefacts.
Please make sure these boxes are checked before submitting your pull request - thanks!
gradle testto make sure you didn't break anything