Skip to content

feat: replace GTFS Components language to GTFS features#1696

Merged
cka-y merged 3 commits intomasterfrom
feat/1685
Mar 8, 2024
Merged

feat: replace GTFS Components language to GTFS features#1696
cka-y merged 3 commits intomasterfrom
feat/1685

Conversation

@cka-y
Copy link
Copy Markdown
Contributor

@cka-y cka-y commented Mar 7, 2024 •
edited
Loading

Summary:
Closes #1685
Modification to the "GTFS Components" label and replace it with "GTFS Features" so it's harmonized across the Mobility Database and gtfs.org

Expected behavior:

Please make sure these boxes are checked before submitting your pull request - thanks!

@cka-y cka-y marked this pull request as ready for review March 7, 2024 16:25
qcdyx
qcdyx approved these changes Mar 7, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@qcdyx qcdyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

emmambd
emmambd approved these changes Mar 7, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@emmambd emmambd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cka-y Flagging that this features change doesn't include the components list and the deprecated notation in the JSON report like the issue described, BUT given that we're implementing another breaking change in this release already, it seems simpler just to tell users that need to make these modifications in this release rather than providing a transition period. I approve.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 7, 2024

✅ Rule acceptance tests passed.
New Errors: 0 out of 1520 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Errors: 0 out of 1520 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
New Warnings: 0 out of 1520 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Warnings: 0 out of 1520 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
0 out of 1520 sources (~0 %) are corrupted.
Commit: 6aefb25
Download the full acceptance test report here (report will disappear after 90 days).
✅ Rule acceptance tests passed.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 7, 2024

✅ Rule acceptance tests passed.
New Errors: 0 out of 1520 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Errors: 0 out of 1520 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
New Warnings: 0 out of 1520 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Warnings: 0 out of 1520 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
0 out of 1520 sources (~0 %) are corrupted.
Commit: b164804
Download the full acceptance test report here (report will disappear after 90 days).
✅ Rule acceptance tests passed.

davidgamez
davidgamez approved these changes Mar 7, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@davidgamez davidgamez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 7, 2024

✅ Rule acceptance tests passed.
New Errors: 0 out of 1520 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Errors: 0 out of 1520 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
New Warnings: 0 out of 1520 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Warnings: 0 out of 1520 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
0 out of 1520 sources (~0 %) are corrupted.
Commit: 0b41a94
Download the full acceptance test report here (report will disappear after 90 days).
✅ Rule acceptance tests passed.

@cka-y cka-y merged commit 5b923ea into master Mar 8, 2024
@cka-y cka-y deleted the feat/1685 branch March 8, 2024 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@davidgamez davidgamez davidgamez approved these changes

@qcdyx qcdyx qcdyx approved these changes

@emmambd emmambd emmambd approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Replace GTFS Components language to GTFS features

4 participants

@cka-y @davidgamez @qcdyx @emmambd