Skip to content

fix: table not properly rendered in notices#1695

Merged
cka-y merged 1 commit intomasterfrom
feat/1672
Mar 7, 2024
Merged

fix: table not properly rendered in notices#1695
cka-y merged 1 commit intomasterfrom
feat/1672

Conversation

@cka-y
Copy link
Copy Markdown
Contributor

@cka-y cka-y commented Mar 7, 2024 •
edited
Loading

Summary:
Closes #1672
Tables in Markdown format do not properly render for notices fast_travel_between_consecutive_stops and duplicate_route_name. To address the issue I simply used HTML formatting like it was done for the route_long_name_contains_short_name notice.

Expected behavior:

  • For fast_travel_between_consecutive_stops:
    image
  • For duplicate_route_name:
    image

Please make sure these boxes are checked before submitting your pull request - thanks!

@cka-y cka-y marked this pull request as ready for review March 7, 2024 16:09
qcdyx
qcdyx approved these changes Mar 7, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@qcdyx qcdyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 7, 2024

✅ Rule acceptance tests passed.
New Errors: 0 out of 1520 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Errors: 0 out of 1520 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
New Warnings: 0 out of 1520 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Warnings: 0 out of 1520 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
0 out of 1520 sources (~0 %) are corrupted.
Commit: 621f3f2
Download the full acceptance test report here (report will disappear after 90 days).
✅ Rule acceptance tests passed.

@cka-y cka-y merged commit ff04760 into master Mar 7, 2024
@cka-y cka-y deleted the feat/1672 branch March 7, 2024 17:27
emmambd added a commit that referenced this pull request Mar 12, 2024
@emmambd
fix table to match #1695
ec2803f
qcdyx added a commit that referenced this pull request Mar 13, 2024
@emmambd @davidgamez @qcdyx
feat: Add examples table for mixed_case_recommended_field (#1708)
4029a37 
* add table

* fix table to match #1695

* fix java doc error

* update caption styles

* web ui style update + add colons

---------

Co-authored-by: David Gamez Diaz <[email protected]>
Co-authored-by: Jingsi Lu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@qcdyx qcdyx qcdyx approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Table not properly rendered in notices

2 participants

@cka-y @qcdyx