Skip to content

feat: used the standard date time formatter#1691

Merged
qcdyx merged 4 commits intomasterfrom
1652-make-the-datetime-in-the-json-report-for-validatedat-a-standard-format
Mar 7, 2024
Merged

feat: used the standard date time formatter#1691
qcdyx merged 4 commits intomasterfrom
1652-make-the-datetime-in-the-json-report-for-validatedat-a-standard-format

Conversation

@qcdyx
Copy link
Copy Markdown
Contributor

@qcdyx qcdyx commented Mar 6, 2024

Summary:
Closes #1652
image
report.json

Expected behavior:

Please see the validatedAt string on the screenshot and json report.

Please make sure these boxes are checked before submitting your pull request - thanks!

@qcdyx qcdyx requested a review from jcpitre March 6, 2024 21:18
@davidgamez
Copy link
Copy Markdown
Member

Can we remove the milliseconds and the name of the timezone? Example: 2024-01-15T24:14:45+05:00

@qcdyx
Copy link
Copy Markdown
Contributor Author

qcdyx commented Mar 6, 2024

image
report.json
Voila @davidgamez

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 6, 2024

✅ Rule acceptance tests passed.
New Errors: 0 out of 1520 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Errors: 0 out of 1520 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
New Warnings: 0 out of 1520 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Warnings: 0 out of 1520 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
0 out of 1520 sources (~0 %) are corrupted.
Commit: d8d6966
Download the full acceptance test report here (report will disappear after 90 days).
✅ Rule acceptance tests passed.

@qcdyx
Copy link
Copy Markdown
Contributor Author

qcdyx commented Mar 7, 2024

Regarding when --date is passed in the validator question @davidgamez, I tried java -Xmx1G -jar ./cli/build/libs/gtfs-validator-4.2.1-SNAPSHOT-cli.jar -d 2023-01-01 -o /Users/jingsi/code/data/gtfs-ws/delfi -i /Users/jingsi/Downloads/google-transit-darwin-200124.zip and it's working.
image

Copy link
Copy Markdown
Member

@davidgamez davidgamez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 7, 2024

✅ Rule acceptance tests passed.
New Errors: 0 out of 1520 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Errors: 0 out of 1520 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
New Warnings: 0 out of 1520 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Warnings: 0 out of 1520 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
0 out of 1520 sources (~0 %) are corrupted.
Commit: 94243f8
Download the full acceptance test report here (report will disappear after 90 days).
✅ Rule acceptance tests passed.

@qcdyx qcdyx merged commit 4df6de3 into master Mar 7, 2024
@qcdyx qcdyx deleted the 1652-make-the-datetime-in-the-json-report-for-validatedat-a-standard-format branch March 7, 2024 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make the date+time in the JSON report for "validatedAt" a standard format

2 participants