Skip to content

fix: cypress tests pointing to production are triggered on PRs checks#1687

Merged
davidgamez merged 17 commits intomasterfrom
fix/local-cypress-tests
Mar 6, 2024
Merged

fix: cypress tests pointing to production are triggered on PRs checks#1687
davidgamez merged 17 commits intomasterfrom
fix/local-cypress-tests

Conversation

@davidgamez
Copy link
Copy Markdown
Member

@davidgamez davidgamez commented Mar 5, 2024 •
edited
Loading

Summary:

Major changes in this PR:

  • Cypress tests can be run locally
  • A few JS dependencies needed to be updated due to incompatibility issues running on GitHub actions with latest Cypress library
  • Node version updated to 20 as 16 ended its support late last year(2023).
  • Updated GitHub actions plugin versions in all modified workflow as GitHub is warning the end of support life actions using Node 16
  • Fixed intermittent failures on Cypress

Closes: #1616
Closes: #1411

Expected behavior:

  • Cypress tests can be run locally
  • Cypress tests run on GitHub actions against a local server rather than a live server like QA or PROD

Please make sure these boxes are checked before submitting your pull request - thanks!

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 5, 2024

✅ Rule acceptance tests passed.
New Errors: 0 out of 1520 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Errors: 0 out of 1520 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
New Warnings: 0 out of 1520 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Warnings: 0 out of 1520 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
0 out of 1520 sources (~0 %) are corrupted.
Commit: d879d99
Download the full acceptance test report here (report will disappear after 90 days).
✅ Rule acceptance tests passed.

@davidgamez davidgamez mentioned this pull request Mar 6, 2024
Closed
@davidgamez davidgamez marked this pull request as ready for review March 6, 2024 18:01
qcdyx
qcdyx approved these changes Mar 6, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@qcdyx qcdyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

davidgamez
davidgamez commented Mar 6, 2024
View reviewed changes
web/client/README.md
## Developing

Once you've created a project and installed dependencies with `npm install` (or `pnpm install` or `yarn`), start a development server:
Once you've created a project and installed dependencies with `npm install`, start a development server:
Copy link
Copy Markdown
Member Author

@davidgamez davidgamez Mar 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Select npm as the package manager to avoid non-deterministic builds using different package managers concurrently on the repository.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 6, 2024

✅ Rule acceptance tests passed.
New Errors: 0 out of 1520 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Errors: 0 out of 1520 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
New Warnings: 0 out of 1520 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Warnings: 0 out of 1520 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
0 out of 1520 sources (~0 %) are corrupted.
Commit: 8ca8117
Download the full acceptance test report here (report will disappear after 90 days).
✅ Rule acceptance tests passed.

@davidgamez davidgamez merged commit d631b1a into master Mar 6, 2024
@davidgamez davidgamez deleted the fix/local-cypress-tests branch March 6, 2024 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@qcdyx qcdyx qcdyx approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Cypress tests pointing to production are triggered on PRs checks ci: Cypress tests failing intermittently

2 participants

@davidgamez @qcdyx