Skip to content

feat: 1651 web validator retries with bad zip file 2#1686

Merged
qcdyx merged 11 commits intomasterfrom
1651-web-validator-retries-with-bad-zip-file-2
Mar 6, 2024
Merged

feat: 1651 web validator retries with bad zip file 2#1686
qcdyx merged 11 commits intomasterfrom
1651-web-validator-retries-with-bad-zip-file-2

Conversation

@qcdyx
Copy link
Copy Markdown
Contributor

@qcdyx qcdyx commented Mar 5, 2024

Summary:
Part of #1651
setup GCP logging configuration so each log entry contains span ID information.

Expected behavior:

Explain and/or show screenshots for how you expect the pull request to work in your testing (in case other devices exhibit different behavior).

Please make sure these boxes are checked before submitting your pull request - thanks!

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 5, 2024

This contribution does not follow the conventions set by the Google Java style guide. Please run the following command line at the root of the project to fix formatting errors: ./gradlew goJF.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 5, 2024

✅ Rule acceptance tests passed.
New Errors: 0 out of 1520 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Errors: 0 out of 1520 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
New Warnings: 0 out of 1520 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Warnings: 0 out of 1520 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
0 out of 1520 sources (~0 %) are corrupted.
Commit: fe62ade
Download the full acceptance test report here (report will disappear after 90 days).
✅ Rule acceptance tests passed.

@qcdyx qcdyx requested a review from davidgamez March 6, 2024 01:09
@emmambd emmambd linked an issue Mar 6, 2024 that may be closed by this pull request
Copy link
Copy Markdown
Member

@davidgamez davidgamez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

…le-2

# Resolved Conflicts:
#	.github/workflows/stg_web_svc_merge.yml
@qcdyx qcdyx merged commit bf25c9b into master Mar 6, 2024
@qcdyx qcdyx deleted the 1651-web-validator-retries-with-bad-zip-file-2 branch March 6, 2024 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Web validator retries with bad zip file

2 participants