Skip to content

fix: reformatted doc using HTML table format#1669

Merged
qcdyx merged 3 commits intomasterfrom
1624-problem-with-how-the-route_long_name_contains_short_name-description-renders-on-the-html-report
Feb 14, 2024
Merged

fix: reformatted doc using HTML table format#1669
qcdyx merged 3 commits intomasterfrom
1624-problem-with-how-the-route_long_name_contains_short_name-description-renders-on-the-html-report

Conversation

@qcdyx
Copy link
Copy Markdown
Contributor

@qcdyx qcdyx commented Feb 12, 2024

Summary:

Closes #1624
Expected behavior:
image

Please make sure these boxes are checked before submitting your pull request - thanks!

@github-actions
Copy link
Copy Markdown
Contributor

This contribution does not follow the conventions set by the Google Java style guide. Please run the following command line at the root of the project to fix formatting errors: ./gradlew goJF.

@qcdyx qcdyx requested review from emmambd and jcpitre February 12, 2024 18:06
Copy link
Copy Markdown
Contributor

@emmambd emmambd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On a QA side, looks good to me! Opened the report and the markdown is formatted correctly now.

@github-actions
Copy link
Copy Markdown
Contributor

✅ Rule acceptance tests passed.
New Errors: 0 out of 1484 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Errors: 0 out of 1484 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
New Warnings: 0 out of 1484 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Warnings: 0 out of 1484 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
2 out of 1486 sources (~0 %) are corrupted.
Corrupted sources:
at-wien-wiener-lokalbahnen-wlb-gtfs-648
ca-ontario-transit-windsor-gtfs-720
Commit: ec80082
Download the full acceptance test report here (report will disappear after 90 days).
✅ Rule acceptance tests passed.

Copy link
Copy Markdown
Contributor

@jcpitre jcpitre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@github-actions
Copy link
Copy Markdown
Contributor

This contribution does not follow the conventions set by the Google Java style guide. Please run the following command line at the root of the project to fix formatting errors: ./gradlew goJF.

…contains_short_name-description-renders-on-the-html-report
@qcdyx qcdyx merged commit 69b948e into master Feb 14, 2024
@qcdyx qcdyx deleted the 1624-problem-with-how-the-route_long_name_contains_short_name-description-renders-on-the-html-report branch February 14, 2024 14:47
@github-actions
Copy link
Copy Markdown
Contributor

✅ Rule acceptance tests passed.
New Errors: 0 out of 1485 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Errors: 0 out of 1485 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
New Warnings: 0 out of 1485 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Warnings: 0 out of 1485 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
1 out of 1486 sources (~0 %) are corrupted.
Corrupted sources:
us-colorado-san-miguel-authority-for-regional-transportation-smart-gtfs-811
Commit: 701be27
Download the full acceptance test report here (report will disappear after 90 days).
✅ Rule acceptance tests passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Problem with how the route_long_name_contains_short_name description renders on the HTML report

3 participants