Skip to content

feat: display ERRORS first on validator documentation#1667

Merged
cka-y merged 6 commits intomasterfrom
feat/1605
Mar 12, 2024
Merged

feat: display ERRORS first on validator documentation#1667
cka-y merged 6 commits intomasterfrom
feat/1605

Conversation

@cka-y
Copy link
Copy Markdown
Contributor

@cka-y cka-y commented Feb 9, 2024

Summary:
Closes #1605

Expected behavior:
ERROR notices are displayed first, followed by WARNING and then INFO in both the documentation and validation report.

Screenshot 2024-02-09 at 2 33 56 PM

Screenshot 2024-02-27 at 1 34 49 PM

Please make sure these boxes are checked before submitting your pull request - thanks!

Copy link
Copy Markdown
Contributor

@qcdyx qcdyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@emmambd
Copy link
Copy Markdown
Contributor

emmambd commented Feb 20, 2024

@cka-y It looks like this original order is also affecting the actual HTML report (it's warning, info, error right now). I assume this would be a different issue - is that correct?

@cka-y
Copy link
Copy Markdown
Contributor Author

cka-y commented Feb 27, 2024

@cka-y It looks like this original order is also affecting the actual HTML report (it's warning, info, error right now). I assume this would be a different issue - is that correct?

I included it as part of this PR

@cka-y cka-y requested a review from qcdyx February 27, 2024 18:40
Copy link
Copy Markdown
Contributor

@emmambd emmambd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after testing order on a few feeds

@github-actions
Copy link
Copy Markdown
Contributor

✅ Rule acceptance tests passed.
New Errors: 0 out of 1502 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Errors: 0 out of 1502 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
New Warnings: 0 out of 1502 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Warnings: 0 out of 1502 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
3 out of 1505 sources (~0 %) are corrupted.
Corrupted sources:
ae-abu-dhabi-emirate-department-of-municipalities-and-transport-gtfs-1329
at-wien-wiener-lokalbahnen-wlb-gtfs-648
ca-quebec-societe-des-transports-de-rimouski-gtfs-760
Commit: 7dc620f
Download the full acceptance test report here (report will disappear after 90 days).
✅ Rule acceptance tests passed.

Copy link
Copy Markdown
Contributor

@jcpitre jcpitre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I asked a question on a minor point, but could be merged as-is.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 6, 2024

✅ Rule acceptance tests passed.
New Errors: 0 out of 1520 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Errors: 0 out of 1520 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
New Warnings: 0 out of 1520 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Warnings: 0 out of 1520 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
0 out of 1520 sources (~0 %) are corrupted.
Commit: a1a0465
Download the full acceptance test report here (report will disappear after 90 days).
✅ Rule acceptance tests passed.

@cka-y cka-y requested review from davidgamez and removed request for qcdyx March 8, 2024 19:58
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 8, 2024

✅ Rule acceptance tests passed.
New Errors: 0 out of 1520 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Errors: 0 out of 1520 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
New Warnings: 0 out of 1520 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Warnings: 0 out of 1520 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
0 out of 1520 sources (~0 %) are corrupted.
Commit: 4695ba4
Download the full acceptance test report here (report will disappear after 90 days).
✅ Rule acceptance tests passed.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 8, 2024

✅ Rule acceptance tests passed.
New Errors: 0 out of 1520 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Errors: 0 out of 1520 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
New Warnings: 0 out of 1520 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Warnings: 0 out of 1520 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
0 out of 1520 sources (~0 %) are corrupted.
Commit: 9b32d42
Download the full acceptance test report here (report will disappear after 90 days).
✅ Rule acceptance tests passed.

Copy link
Copy Markdown
Member

@davidgamez davidgamez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@github-actions
Copy link
Copy Markdown
Contributor

✅ Rule acceptance tests passed.
New Errors: 0 out of 1520 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Errors: 0 out of 1520 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
New Warnings: 0 out of 1520 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Warnings: 0 out of 1520 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
0 out of 1520 sources (~0 %) are corrupted.
Commit: ac1f878
Download the full acceptance test report here (report will disappear after 90 days).
✅ Rule acceptance tests passed.

@cka-y cka-y merged commit 16d20e0 into master Mar 12, 2024
@cka-y cka-y deleted the feat/1605 branch March 12, 2024 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Display ERRORS first on validator documentation

5 participants