Conversation
|
@cka-y It looks like this original order is also affecting the actual HTML report (it's warning, info, error right now). I assume this would be a different issue - is that correct? |
I included it as part of this PR |
emmambd
left a comment
There was a problem hiding this comment.
LGTM after testing order on a few feeds
|
✅ Rule acceptance tests passed. |
model/src/main/java/org/mobilitydata/gtfsvalidator/notice/SeverityLevel.java
Outdated
Show resolved
Hide resolved
jcpitre
left a comment
There was a problem hiding this comment.
I asked a question on a minor point, but could be merged as-is.
main/src/main/java/org/mobilitydata/gtfsvalidator/report/model/ReportSummary.java
Outdated
Show resolved
Hide resolved
|
✅ Rule acceptance tests passed. |
|
✅ Rule acceptance tests passed. |
|
✅ Rule acceptance tests passed. |
|
✅ Rule acceptance tests passed. |
Summary:
Closes #1605
Expected behavior:
ERRORnotices are displayed first, followed byWARNINGand thenINFOin both the documentation and validation report.Please make sure these boxes are checked before submitting your pull request - thanks!
gradle testto make sure you didn't break anything