Conversation
…n component names. Refactored a bit.
|
✅ Rule acceptance tests passed. |
|
@qcdyx I made some changes in the code that you could review. You don't need to review the markdown file. |
emmambd
left a comment
There was a problem hiding this comment.
@jcpitre This looks good! I think it would be good to link to the public GTFS components document in the "list of components" text at the top.
docs/features.md
Outdated
|
|
||
| The validator will list the list of components that it finds in the processed feed according to this table: | ||
|
|
||
| | Component | Feature | How is the presence of a featuree determined (minimum requirements) | |
There was a problem hiding this comment.
typo: featuree should be feature
|
It's being used in public facing meetings, so we can go ahead and add it. It's important context for anyone who reads the documentation and doesn't know what components are. |
|
✅ Rule acceptance tests passed. |
Added the link |
Summary:
Closes #1661
Added a document with the list of components-features and how we determine if they are present.
Removed Blocks component
Corrected the code where components were duplicated because of a typo in their name,
Expected behavior:
I expect no change of behavior.
Please make sure these boxes are checked before submitting your pull request - thanks!
gradle testto make sure you didn't break anything